Spice netlist

[JKB]

Hello,

I have upgraded my kicad installation yesterday and I have found a bug in spice netlist.

For example, if I add in schematic :
.tran 10n 1m
.options method=gear reltol=1m minbreak=200ps
.control
    run
    write results.raw
    quit
.endc

only lines that begin with a dot are exported in spice netlist and I obtain :
Q4 Net-_Q4-Pad1_ /Vc /Vs BC32725
XM1 Net-_M1-Pad1_ /Vs Net-_D1-Pad2_ NC_01 irf9540npbf
R7 Net-_M1-Pad1_ 0 2.8
V3 Net-_Q4-Pad1_ 0 0
.tran 10n 1m
.options method=gear reltol=1m minbreak=200ps
.control
.endc

Of course, before my upgrade, spice netlist was created as expected.

Best regards,

JB

Application: kicad
Version: (5.0.1-dev-36-g831978293), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.0 GnuTLS/3.5.19 zlib/1.2.11 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.32.0 librtmp/2.3
Platform: Linux 4.16.0-2-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[JKB (joel-bertrand)]

This bug seems to be added by this patch :
https://git.launchpad.net/kicad/commit/eeschema/netlist_exporters/netlist_exporter_pspice.cpp?id=d5ee3296b200a7ccd863209390fe66a71b192dae

[JKB (joel-bertrand)]

Please patch.

Best regards,

JKB

[Wayne Stambaugh (stambaughw)]

@Orson, please take a look at the included patch and see if makes sense for the spice text parser.

@JKB, for future patches please follow the KiCad coding policy[1]. In this case it's a small patch so if your patch gets accepted, the lead dev will most likely fix the violations for you.

[1]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html

[Maciej Suminski (orsonmmz)]

@Wayne
Thank you for the reminder, I could recall there is such patch somewhere, but I could not find it. The changes look fine to me, I have already fixed the code formatting violations, so I am ready to merge it.

@JKB
Could you give credentials that I should use in the 'author' field of the patch?

[JKB (joel-bertrand)]

You can use
Joël Bertrand <email address hidden>

Best regards,

JKB

[Maciej Suminski (orsonmmz)]

JKB,

I have pushed your patch (36f2eb11), thank you for your contribution! In case you would like to send us more patches, we would greatly appreciate creating using with git-format, so they contain description and author of the patch - it makes our lifes much easier.

[JKB (joel-bertrand)]

Maciej Suminski a écrit :
> JKB,
>
> I have pushed your patch (36f2eb11), thank you for your contribution! In
> case you would like to send us more patches, we would greatly appreciate
> creating using with git-format, so they contain description and author
> of the patch - it makes our lifes much easier.

 Thanks, I will try. This patch was only a quick and dirty patch. I have
seen it was pushed in master branch. A chance to push the same in 5.0 ?

 Best regards,

 JKB

[Maciej Suminski (orsonmmz)]

I have actually pushed it to my 5.0 branch and just today I discovered that none of my previous commits got to the official repository as I had wrong remote specified - thank you for noting. Now everything should be already in place.