Hierarchical Sheet Pin names not highlighted by default

Bug #1785840 reported by Evan Shultz on 2018-08-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Low
Wayne Stambaugh

Bug Description

In 5.0.0, the "name" field is highlighted by default when viewing the properties of a named element. The "name" would be the ref des of a component (the number part), the name of a net label, etc.

However, hierarchical sheet pins do not get anything highlighted in the dialog. The Sheet Pin Properties dialog should have the Name field highlighted to match the behavior elsewhere in v5.Application: kicad
Version: (5.0.0), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

tags: added: ui
Jeff Young (jeyjey) wrote :

Already fixed in 5.1.

Changed in kicad:
status: New → Fix Committed
Changed in kicad:
milestone: none → 5.1.0
tags: removed: ui
Evan Shultz (evan-shultz) wrote :

This still happens with a fairly recent nightly.

I've made a short video to illustrate what's going on. On a symbol the "Reference" text box is highlighted and typing clears out the old text and replaces it. The same with a label and it's "Label" text box.

But with a Sheet Pin, no text in the "Name" text box is highlighted and the cursor is at the left of the text box. So typing instead adds the characters to the beginning of the text.

Application: kicad
Version: (6.0.0-rc1-dev-1521-g81a0ab4d7), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
status: Fix Committed → Confirmed
importance: Undecided → Low
assignee: nobody → Wayne Stambaugh (stambaughw)
status: Confirmed → In Progress
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 7789ec4bf1959f3822c86ef959bb496e561a7c95
https://git.launchpad.net/kicad/patch/?id=7789ec4bf1959f3822c86ef959bb496e561a7c95

Changed in kicad:
status: In Progress → Fix Committed
Wayne Stambaugh (stambaughw) wrote :

This should be fixed in 5.1.0-rc1-5-g7789ec4bf. Please let me know if you are still having issues.

Evan Shultz (evan-shultz) wrote :

Yep. Sheet Pin names are now highlighted when the dialog is invoked. Thanks Wayne!

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments