Cancel Add dimension leaves auto panning on

[ronnie]

Steps to reproduce:
1) Select "Add Dimension" tool
2) Define first point
3) Cancel the tool before second point is defined

=> Auto pan will still be active.

Attached patch fixes the issue.

Application: pcbnew
Version: (6.0.0-rc1-dev-254-g7fa5456-dirty), debug build
Libraries:
    wxWidgets 3.0.2
Platform: Linux 4.4.0-131-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[ronnie (ronnie81)]

Had uploaded the wrong patch at creating the report. File at #2 is the correct one.

[Maciej Suminski (orsonmmz)]

Hi Ronnie,

Thank you for the patch, I am going to merge it. If possible, please use git format-patch to create patches, it makes our lives much easier. Do you want to give your name and e-mail address to put in the author line for the commit?

[ronnie (ronnie81)]

Thanks for your feedback Maciej! I'll attach a proper patch. There is also my full name and mail. I hope the new patch fits your requirements.

[Maciej Suminski (orsonmmz)]

That is exactly what I had in mind, thanks! I have adjusted the commit message to include an info line for the bug tracker bot [1].

1. http://docs.kicad-pcb.org/doxygen/commit_messages.html#commit_bug_link

[Maciej Suminski (orsonmmz)]

My bad, I missed the last digit of the bug report ID, so bot has not picked it up and I will have to do his job: Fixed in commit 3ca84dca.

[ronnie (ronnie81)]

Thank you! I'll read the documentation to be prepared for the next patch (and prob fix the ones already posted on other bugs).