Call to LoadFromLibrary in onleftclick.cpp

[ronnie]

LoadFromLibrary called from pcbnew/onleftclick.cpp:371
MODULE* module = LoadModuleFromLibrary( wxEmptyString, Prj().PcbFootprintLibs() );

but defined as following:
pcb_base_frame.h:457
MODULE* PCB_BASE_FRAME::LoadModuleFromLibrary( const wxString& aLibrary, bool aUseFootprintViewer )

Second argument fo function is supposed to be bool. But here it's FP_LIB_TABLE* PROJECT::PcbFootprintLibs().

Prob not causing issues, but still a bug IMHO

Index: pcbnew/onleftclick.cpp
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- pcbnew/onleftclick.cpp (revision 099fcf1247593a499026372eb3b26eb662fa730d)
+++ pcbnew/onleftclick.cpp (date 1532756305000)
@@ -368,7 +368,7 @@
         if( (curr_item == NULL) || (curr_item->GetFlags() == 0) )
         {
             m_canvas->MoveCursorToCrossHair();
- MODULE* module = LoadModuleFromLibrary( wxEmptyString, Prj().PcbFootprintLibs() );
+ MODULE* module = LoadModuleFromLibrary( wxEmptyString );

             SetCurItem( (BOARD_ITEM*) module );

[Jeff Young (jeyjey)]

@ronnie, thanks for the bug report and patch!

I didn't merge it because we now use a Library Tree for Place Footprint (a la Place Symbol), so that code no longer exists. But your contribution is still valued. :)

Cheers,
Jeff.

[ronnie (ronnie81)]

@Jeff, thanks for the feedback. I hadn't fetched for a couple days... I just did so now and saw your changes.