Typo in Footprint Editor Properties dialog tooltips

[Evan Shultz]

1. Open Footprint Editor and click the footprint Properties icon to open the Footprint Properties dialog.
2. However over the "solder paste ratio clearance" text to see the tooltip.
3. The first line of text seems to have a new line in the middle of the sentence ("...paste\nfor this footprint.").
4. Also, in the three clearance pop ups there are sentences ending in periods and some with no periods. It seems random.
5. Lastly, is "per cent" intended to have a space in the middle? https://english.stackexchange.com/questions/105295/percent-or-per-cent states that US English most commonly does not use the space (this is true coming from an American). I see other spelling throughout KiCad is US English and not UK English (at least on my PC with the OS language set to US-EN).

6. Now go to the properties of a single padstack and click the "Local Clearance and Settings" tab.
7. In both the "Net pad clearance" and "Solder mask clearance" tooltips there is an extra space before the word "pad" in the first sentence.
8. See the items listed above in the padstack instance tooltips as well.

Application: kicad
Version: (5.0.0), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[John Beard (john-j-beard)]

Fixes these issues and couple more (handful of commas and some double full stops).

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1e11df650cdfb431680f29ee6bfb0a747ca1192c
https://git.launchpad.net/kicad/patch/?id=1e11df650cdfb431680f29ee6bfb0a747ca1192c

[Evan Shultz (evan-shultz)]

I still see weirdness with the version below.

3. Instead of showing the newline character, the newline is being applied inside the dialog and splitting up the sentence. Screenshot attached.

4. Still some periods at the end of sentences and other sentences without periods.

5. Still a space in "percent". While Preferences > Set Language > English uses the British flag, the Layers Manager uses "color" and not "colour" (as just one example) so I think this is either a typo or an outlier by using the British spelling.

6-8. This dialog looks good, so perhaps the patch addressed the Pad Properties dialog but not the Footprint Properties dialog?

Application: kicad
Version: (6.0.0-rc1-dev-1521-g81a0ab4d7), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I believe all the remaining issues are fixed in my 6.0 tree, but we're past string freeze for 5.1.

[Wayne Stambaugh (stambaughw)]

We could do this as part of a 5.1.1 release which can have it's own string freeze. Obviously we would want to keep the 5.1 branch string changes to a minimum but I'm guessing most of them would be spelling, grammar, and minor formatting issues.

[Evan Shultz (evan-shultz)]

Then should this bug not be marked as "Fix Committed"? Won't the script close this once 5.1 is released and all resolved bugs are scrubbed?

[Jeff Young (jeyjey)]

"Fix Committed" means to master. Currently, they're only committed to my local repository.

[Wayne Stambaugh (stambaughw)]

@Jeff, would you please cherry-pick this commit to the 5.1 branch when you get a chance? Thanks!