Wishlist: In Cvpcb make double-clicking a library toggle the "filter footprint list by library" filter on and off

Bug #1780487 reported by Gabriel Staples on 2018-07-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Undecided
Jeff Young

Bug Description

Application: kicad
Version: 5.0.0-rc2-dev-unknown-f73b9a5~65~ubuntu14.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 4.4.0-112-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.54.0
    Curl: 7.35.0
    Compiler: GCC 4.8.4 with C++ ABI 1002
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

--------------------------------------------

Double-clicking a library name in Cvpcb footprint selector to toggle the "filter footprint list by library" filter on and off would be a useful addition.

Gabriel Staples (ercaguy) wrote :

screenshot of what cvpcb currently looks like. The "filter footprint list by library" filter is the one at the top-right with an "L" on the lower-right of the icon.

Gabriel Staples (ercaguy) wrote :

screenshot

Jeff Young (jeyjey) wrote :

There is no value in clicking on a footprint library if the filter is off. So I think if one /does/ click on a library, it's clear enough that they want the filter on. No need to wait for a double click.

Turning off the filter I think is still easiest by using the filter button.

So I wouldn't be inclined to add any double-click processing; selection should just turn the filter on.

Jeff Young (jeyjey) on 2018-07-11
Changed in kicad:
status: New → In Progress
assignee: nobody → Jeff Young (jeyjey)
milestone: none → 5.1.0
Gabriel Staples (ercaguy) wrote :

Sounds fine. I'd still think a double click to unselect is a nice addition but obviously just clicking the filter button works too.

Is it possible for me to see your commits which implement this in GitHub? (Or just on my PC in git). I don't know what you as developers currently do when you implement and close a request but if you post a GitHub link to the commit and/or a commit hash here afterwards, and as a general practice for all bug fixes or wishlist items, I'd be inclined to start getting familiar with the source code to maybe contribute to source code someday too.

Jeff Young (jeyjey) wrote :

@eRCaGuy, there's a public mirror of my repo at: https://code.launchpad.net/~jeyjey/kicad/+git/kicad .

Nick and I have been working through building it on Linux, but right now it's only guaranteed to compile on OSX.

If you do try to compile it on Windows or Linux, please let me know of any issues you run into and I'll get them fixed up.

We look forward to your possible contributions in the future!

Gabriel Staples (ercaguy) wrote :

I cloned your repo, so when you complete any of my wishlist items or bug-fixes I've submitted feel free to message me and tell me from which commit hash to which commit hash is the full fix and I'll `git pull` and `git difftool` it to take a look at the source code.

Jeff Young (jeyjey) on 2018-07-17
Changed in kicad:
status: In Progress → Fix Committed
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 504826074994371ebf6f8274c3f49d39aec1e531
https://git.launchpad.net/kicad/patch/?id=504826074994371ebf6f8274c3f49d39aec1e531

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers