Move status messages to Eeschema find dialog and implement "n of m" status line

Bug #1777699 reported by Gabriel Staples on 2018-06-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Jeff Young

Bug Description

Application: eeschema
Version: 5.0.0-rc2-dev-unknown-f73b9a5~65~ubuntu14.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.35.0 OpenSSL/1.0.1f zlib/1.2.8 libidn/1.28 librtmp/2.3
Platform: Linux 4.4.0-112-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.54.0
    Curl: 7.35.0
    Compiler: GCC 4.8.4 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON
------------------------------------------------------------

When you try to use the Find dialog to search for something on the sheet, it will not auto-wrap the search. This means that once you press Enter until all matching strings have been found, it won't find the string anymore! This makes the Find dialog appear to be broken. Please add an indicator that says "1/8 matches" for instance, to show which matching string you're on, then have it increment as you press Enter: "2/8 matches", "3/8 matches" etc. Once you get to the end, have it auto-wrap back to the first match, instead of doing nothing, which is what it currently does.

A work-around is to simply search for a new string one time, then put your original string back in and hit enter repeatedly to look at all of the matches again. This is NOT intuitive, however, and took me a while to figure out. Initially I just thought the Find dialog was broken.

Jeff Young (jeyjey) wrote :

Turn on the "Wrap around end of search list" checkbox.

Gabriel Staples (ercaguy) wrote :

Indeed. That does the trick. :) I still think the "1/n matches" would be a nice addition though.

Gabriel Staples (ercaguy) wrote :

And maybe move the wrap checkbox to the top where it's more obvious?

Jeff Young (jeyjey) on 2018-06-20
Changed in kicad:
importance: Undecided → Wishlist
status: New → Triaged
summary: - Find in Eeschema does not auto-wrap search until you change search
- strings
+ Move status messages to Eeschema find dialog and implement "n of m"
+ status line
Changed in kicad:
milestone: none → 6.0.0-rc1
Jeff Young (jeyjey) on 2018-07-05
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
milestone: 6.0.0-rc1 → 5.1.0
status: Triaged → In Progress
Jeff Young (jeyjey) on 2018-07-17
Changed in kicad:
status: In Progress → Fix Committed
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 1bca706115943b64f1ce1d45a549467836dc000e
https://git.launchpad.net/kicad/patch/?id=1bca706115943b64f1ce1d45a549467836dc000e

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers