Component selector search should highlight the best match

Bug #1774110 reported by Oliver on 2018-05-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Jeff Young

Bug Description

This is a follow on from a bug previously reported at https://bugs.launchpad.net/kicad/+bug/1738696

The component filtering does not return the "most appropriate" results based on the search string the user inputs.

Please refer to the attached screen captures.

Refer to the screen-captures here - https://imgur.com/a/JpzbPXI

It seems that the selection algorithm filters the components correctly (only showing ones which match the string in some way). But the weighting algorithm which determines the "best" match out of the returned results does not always work as expected.

Application: kicad
Version: (5.0.0-rc2-dev-789-g6f249e5eb), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Oliver (schrodingersgat) wrote :
Oliver (schrodingersgat) wrote :
Oliver (schrodingersgat) wrote :
Seth Hillbrand (sethh) wrote :

This behavior appears to be limited to MSW. Can anyone recreate this with Linux/Mac?

tags: added: eeschema windows
Wayne Stambaugh (stambaughw) wrote :

I do not see any issues in the videos. I think the expectation of exact matching is the issue. The filtering is not an exact match. I'm not sure about the weighting. Maybe the developer who wrote the filtering code can comment on the weighting.

Oliver (schrodingersgat) wrote :

Wayne, the "filtering" part works as expected. But (and this is how it used to work) it should automatically select the "best" match.

Now "best" could be subjective, but at a bare minimum an exact text match on the part name should be selected first.

This *does* happen for symbols like R / C / L but not for others.

e.g. if I type "SW_SPST", then the first item in the filtered list is "SW_SPST" but the one that actually gets selected is "SW_SPST_Temperature"

In cases where the exact match is not selected, it seems that the one that *does* get selected is always the last item in the filtered list. So perhaps the automatic selection is not being performed at all in these cases.

Seth Hillbrand (sethh) on 2018-06-09
Changed in kicad:
importance: Undecided → Wishlist
milestone: none → 6.0.0-rc1
status: New → Triaged
summary: - Component selector weighting is weird
+ Component selector search should highlight the best match
Jeff Young (jeyjey) on 2018-06-10
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 9edfd25b954cba897a5c5a897c90d18098749c94
https://git.launchpad.net/kicad/patch/?id=9edfd25b954cba897a5c5a897c90d18098749c94

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers