Template selector behaviour

[Andy]

Bug 1492577 (https://bugs.launchpad.net/kicad/+bug/1492577) supposedly fixed a problem, however it results in the need to press the 'validate' button to actually show the 'portable' templates. Whilst a little inconvenient it would be manageable, however pressing validate on the "user" templates does not work. You have to 'browse' to the folder again before pressing validate. This is inconvenient.

I propose that the need to 'browse' for the user template folder be fixed and that the validate function is called when moving between "System templates", "User Templates" and "Portable Templates".

===================
Application: kicad
Version: (5.0.0-rc2-dev-707-g2ed24a4), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.3.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.61.0
    Curl: 7.43.0
    Compiler: Clang 7.3.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[ronnie (ronnie81)]

I can't recreate this issue with 5.0.0-fee4fd1~66~ubuntu16.04.1, release build or I'm missing the point.

After some digging: I think it was fixed with https://git.launchpad.net/kicad/patch/?id=620c2af356914d041be441dec5bd8143b9afd273

@Andy could you verify this?

[ronnie (ronnie81)]

I hesitate to just set this to fix released. Could someone else try to reproduce with the latest 5 release?

[Andy (awmt102)]

Tested with the below release version. When the Project Template Selector opens the system templates are shown. Moving to the User Templates tab shows nothing until the validate button is pressed. Pressing it shows templates correctly. Switching back to the System Templates now shows nothing until the validate button is pressed.

Whether it is a bug or not is debatable, but it feels like it would be relatively easy to force the 'Validate' command when each tab is opened to make for a more seamless experience. (Although I appreciate I may be over simplifying it).

Application: kicad
Version: (5.0.0-3-g5ebb6b6), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.3.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

I cannot duplicate this on ubuntu 17.10 (gnome desktop). I wonder if this another one of those ubuntuisms? Sometimes the kicad packages in the ppa fix issues with ubuntu's kicad packages.

[Seth Hillbrand (sethh)]

This behavior was observed on Mac. I haven't seen it with Debian

[Michael Kavanagh (michaelkavanagh)]

Tested ok on:

Application: kicad
Version: (5.1.0-rc2-26-g1908f772b), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    Curl: 7.54.0
    Compiler: Clang 10.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

@Michael-

Thank you for your contribution to KiCad. It's great to see another Mac dev around. On the patch, I'd prefer to keep the validate button. It can be helpful if the user adds items to their path while KiCad is running and they'd like to reload.

[Michael Kavanagh (michaelkavanagh)]

Thanks @Seth, I will send revised patch. How about changing the button to "Refresh" instead? I think this makes it clearer.

[Seth Hillbrand (sethh)]

That's fine. We're in string freeze at the moment so the string will need to exist elsewhere already. grep for '_( "Refresh" )' to make sure

[Michael Kavanagh (michaelkavanagh)]

Couldn't find "Refresh" anywhere else (surprisingly...) so the attached will have to do.

[Jeff Young (jeyjey)]

You could use an icon button instead. (See DIALOG_FIELDS_EDITOR_GLOBAL for an example.)

> On 3 Mar 2019, at 16:59, Michael Kavanagh <email address hidden> wrote:
>
> Couldn't find "Refresh" anywhere else (surprisingly...) so the attached
> will have to do.
>
> ** Patch added: "0001-Fix-template-selector-notebook-behaviour.patch"
> https://bugs.launchpad.net/kicad/+bug/1773510/+attachment/5243083/+files/0001-Fix-template-selector-notebook-behaviour.patch
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1773510
>
> Title:
> Template selector behaviour
>
> Status in KiCad:
> Triaged
>
> Bug description:
> Bug 1492577 (https://bugs.launchpad.net/kicad/+bug/1492577) supposedly
> fixed a problem, however it results in the need to press the
> 'validate' button to actually show the 'portable' templates. Whilst a
> little inconvenient it would be manageable, however pressing validate
> on the "user" templates does not work. You have to 'browse' to the
> folder again before pressing validate. This is inconvenient.
>
> I propose that the need to 'browse' for the user template folder be
> fixed and that the validate function is called when moving between
> "System templates", "User Templates" and "Portable Templates".
>
>
> ===================
> Application: kicad
> Version: (5.0.0-rc2-dev-707-g2ed24a4), release build
> Libraries:
> wxWidgets 3.0.4
> libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
> Platform: Mac OS X (Darwin 17.3.0 x86_64), 64 bit, Little endian, wxMac
> Build Info:
> wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
> Boost: 1.61.0
> Curl: 7.43.0
> Compiler: Clang 7.3.0 with C++ ABI 1002
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=ON
> USE_WX_OVERLAY=ON
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1773510/+subscriptions

[Michael Kavanagh (michaelkavanagh)]

@Jeff I had a go at that but couldn't work out how best to size the button to align with the textCtrl and Browse Button.

[KiCad Janitor (kicad-janitor)]

Fixed in revision c3928c21eb53d15e3a3d14e6295371d4bb0dd240
https://git.launchpad.net/kicad/patch/?id=c3928c21eb53d15e3a3d14e6295371d4bb0dd240

[Seth Hillbrand (sethh)]

Michael- I pushed #10. Thank you for your contribution to KiCad.

The patch in #12 works but the placement of the refresh icon didn't make it clear that it was refreshing the contents of the template directory. We can re-look at the dialog during v6.