add cursor-following status popups to all drawing tools

Bug #1772392 reported by Thomas Pointhuber on 2018-05-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Thomas Pointhuber

Bug Description

Currently, there is a nice helper box displayed beside the cursor when drawing an arc. I would consider it as useful to also add it to the other graphical objects as well:

Line: length and angle starting from the last point
Circle: radius
Polygone: length and angle starting from the last point (or probably to both connected points)

Probably the same for zones and keep out areas as for polygons

# System Information

Application: kicad
Version: (5.0.0-rc2-dev-780-gc49a4398a), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.11 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.31.1
Platform: Linux 4.16.9-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.60.0
    Compiler: Clang 6.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: gal Edit Tag help
Changed in kicad:
importance: Undecided → Wishlist
tags: added: gal
Jeff Young (jeyjey) on 2018-05-22
summary: - add overlays for all graphical objects
+ add cursor-following status popups to all drawing tools
Changed in kicad:
assignee: nobody → Thomas Pointhuber (pointhi)
status: New → In Progress
Thomas Pointhuber (pointhi) wrote :

I did a first implementation of this issue to add status popups to segments and circles.

To achieve this I used the Arc implementation as a blueprint and found out that draw segment lacks a geometric manager. My current implementation of the geometric manager is tied to the visualization part, but I suspect the geometric manager is normally used for more parts of the drawing step.

I didn't want to break anything, so I did not changed the drawSegment Implementation to use the geometric manager for more fundamental things. In the future this should probably be adopted.

Patches can also be found on: https://github.com/pointhi/kicad-source-mirror/commits/status-popup

(Please note, there is another commit in this repo which fixes some spelling issues in the ARC_ASSISTANT)

Thomas Pointhuber (pointhi) wrote :

Known issues of this patches:

* when drawing multiple lines, the popup only appears after moving the mouse slightly
* when drawing multiple lines, the popup always jumps to the lower left side of the cursor as long as it knows no direction.

For the first issue, I have no Idea why it is there. Probably the mouse movement causes the restart of the tool or something like that.

For the second one: the Geometric Manager does not know the last drawn line, which would be a useful hint in the future to prevent those text jumps.

Changed in kicad:
milestone: none → 6.0.0-rc1
Thomas Pointhuber (pointhi) wrote :

I rebased the branch to the current master and fixed a little bug which was exposed by this patchset.

https://github.com/pointhi/kicad-source-mirror/commits/status-popup

Another Issue found (probably related to the new snapping-feature):

* drawing a triangle results in a selection dialogue appearing when finishing the last line.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers