pcbnew: vias not selectable unless top layer is turned on

[Nicholas Savenlid]

cant select TH-vias unless i turn on F.cu and/or B.Cu (visibility check box)

Application: kicad
Version: (5.0.0-rc2-dev-107-g49486b83b), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

@Jon, I think Andrzej posted a patch to fix this on the dev mailing list. You might want to take a look at that before you fix this.

[Jon Evans (craftyjon)]

Andrzej's patches do not address this one unfortunately (but I did push them because they fix some other issues)

[Andrzej Wolski (awolski)]

It so happens that I also have a patch for this issue :)
I did not send it earlier because vias selection worked this way for a long time, so I didn't consider this a bug worth fixing after feature freeze.

@Jon, if you haven't started working on this yet, you may consider attached patch.

[Jon Evans (craftyjon)]

Thanks Andrzej, that works! Committed it.