Crash when duplicating custom pad shape primitives

[Andrzej Wolski]

Use board from attachment.
Duplicate custom pad primitive on pad 5.
Rotation: 20
Duplicate count: 10
Click on primitives list - pcbnew crashes.

Application: pcbnew
Version: (5.0-dev-4088-g5c6b19c55), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Andrzej Wolski (awolski)]

The crash seems to happen only on Windows.
On Linux, primitives list contains "Unknown primitives", see an image.

[KiCad Janitor (kicad-janitor)]

Fixed in revision ee6ac1af1dfbd44bdec0923f5d2b7ee0df243744
https://git.launchpad.net/kicad/patch/?id=ee6ac1af1dfbd44bdec0923f5d2b7ee0df243744