Update macos build instructions about patched wx

[Nick Østergaard]

@Bernhard, I just added this bug for tracking so we won't forget for the release.

https://<email address hidden>/msg28203.html

http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html#build_osx

[Jeff Young (jeyjey)]

If we could get this bit in too, that would be great:

--------------

The OSC install.txt has the following text:

  After Xcode is installed, download wxWidgets-{version}.tar.bz2
  and then double-click on it to unpack it to create a wxWidgets
  directory.

  Next use Terminal...

The Terminal steps will fail, however, because the current version of Xcode moves a bunch of stuff around when you first run it.

So there needs to be another step to launch (and then quit) Xcode.

[Bernhard Stegmaier (stegmaier)]

To be honest, I would completely delete this.

If someone wants to build KiCad, I assume that he/she is able to install Xcode and all of KiCad dependencies (with MacPorts, homebrew, manually, whatever).
I'll just outline how to compile wxWidgets and then KiCad.

I will not write it in a way that any non-developer who has never built something from source will be able to compile KiCad just by going through 50 steps.
That's why nightly builds are there...

[Nick Østergaard (nickoe)]

I guess it is fine as is. I mean it mentions that we need to patch wx, and now it is done differently. And then there is an example of patching and the commands for building. This is good if the dev is not entirely familiar with cmake. I certainly don't expect a 50 step instruction to this. I just expect it to show what wxbranch one should clone and maybe also the configure args we expect to be used.

What is OSC?

[Wayne Stambaugh (stambaughw)]

I don't want the build instructions to be a "how to" for non-developers.
 It should just be a reference for developers for the build
dependencies, configuration options, and caveats for building KiCad from
source. One of the caveats for the macos build would be to use the
custom branch of wxWidgets provided by KiCad and any special
configuration options to build wxWidgets.

Cheers,

Wayne

On 2/13/2018 6:06 AM, Bernhard Stegmaier wrote:
> To be honest, I would completely delete this.
>
> If someone wants to build KiCad, I assume that he/she is able to install Xcode and all of KiCad dependencies (with MacPorts, homebrew, manually, whatever).
> I'll just outline how to compile wxWidgets and then KiCad.
>
> I will not write it in a way that any non-developer who has never built something from source will be able to compile KiCad just by going through 50 steps.
> That's why nightly builds are there...
>

[Bernhard Stegmaier (stegmaier)]

Attached a patch to update compiling.md.
Feel free to change wording if mine is not good enough...

Is there any other place to update?
Doxygen documentation (looks like generated from compiling.md?)? Website?

[Wayne Stambaugh (stambaughw)]

@Bernhard, I merged your patch. Thanks!

On 2/21/2018 11:51 AM, Bernhard Stegmaier wrote:
> Attached a patch to update compiling.md.
> Feel free to change wording if mine is not good enough...
>
> Is there any other place to update?
> Doxygen documentation (looks like generated from compiling.md?)? Website?
>
> ** Patch added: "0001-Update-macOS-compiling-instructions-to-use-KiCad-wxW.patch"
> https://bugs.launchpad.net/kicad/+bug/1749139/+attachment/5059794/+files/0001-Update-macOS-compiling-instructions-to-use-KiCad-wxW.patch
>

[Nick Østergaard (nickoe)]

Changes look good, except that the bundle scripts used for the nightlies are currently on https://github.com/wayneandlayne/KiCadMacOSPackaging.git

The new version that Adam is talking about are intended to be moved to the kicad github org as some other packaging scripts when tested.

[Wayne Stambaugh (stambaughw)]

It appears that someone committed a modified version of this patch so I set the status to fix committed.