DRC Control dialog Cancel and OK buttons

[eelik]

The DRC Control dialog has Cancel and OK buttons. It should have only one button, Close, because the user doesn't accept or cancel anything. Showing/removing the markers and re-filling zones could theoretically be undone, but Cancel and OK are usually for situations when nothing has been done yet outside the dialog.

[jean-pierre charras (jp-charras)]

The DRC Control dialog has Cancel and OK buttons because you can set the minimal track width, the minimal via and micro-via sizes.

"because the user doesn't accept or cancel anything" is false.

[Jeff Young (jeyjey)]

That's only partly true. If you run DRC then they get saved. After that, hitting cancel has no effect (unless you changed them again in the meantime).

Given the "silent save" when running DRC, I'd be inclined to just remove cancel so the user isn't fooled into thinking they can not save any changes.

[jean-pierre charras (jp-charras)]

Remove cancel is good for me.
But remember you need to have a button with id = wxID_CANCEL to be able to close the dialog by ESC key.

[Jeff Young (jeyjey)]

Fix committed to private 6.0 branch:
https://git.launchpad.net/~jeyjey/kicad/commit/?h=6.0&id=3440ccba46d836da510f1ca53edd16a9ec66c5e1