Render/visible checkboxes are full of errors in GAL

[Kristoffer]

When changing render options in pcbnew, the render options are not functional at all.

Examples:

- pads are rendered on copper even though the copper layer is supposed to invisible.
- When disabling rendering of front footprints, F.Silk, F.Adhesive, F.Fab etc is disabled as well
- Disabling text on front only disbles text belonging to footprints, not text on F.Silk or other front layers.
- What is the Margin layer, does nothing?

Application: kicad
Version: (2018-02-08 revision 0c0fe309e)-master, debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.58.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.29.0
Platform: Linux 4.9.79-1-MANJARO x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.66.0
    Curl: 7.58.0
    Compiler: GCC 7.2.1 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Kristoffer (kristoffer-odmark)]

Not only locked to GAL

[Jon Evans (craftyjon)]

Note for posterity: this is basically "by design" right now, although we have agreement that the design should be changed so that these settings make more sense.

[Nick Østergaard (nickoe)]

Are we talking about a regression here, or are we talking about completely changing it to be more user friendly?

[Jon Evans (craftyjon)]

AFAIK there is no regression; this is just a common user complaint that the "Layers" and "Render" visibility settings are linked in non-obvious ways, and this is due to the underlying GAL implementation of linking layers together so they always are shown/hidden together (pads copper / silkscreen / mask / etc)

[Andrzej Wolski (awolski)]

I have fixes for no. 1 and 2, patches here:
https://lists.launchpad.net/kicad-developers/msg34009.html
and here:
https://bugs.launchpad.net/kicad/+bug/1743890/comments/6

In case of no. 3 tooltip says "Show footprint text on board's front", so it's not really a bug.

[Wayne Stambaugh (stambaughw)]

@Andrzej,

Please send me the patch (no. 1)that was sent to the mailing list as an
attachment when you get a chance. It appears that you sent that patch
inline with the email message and I no longer have that email.

Thanks,

Wayne

On 2/18/2018 3:21 PM, Andrzej Wolski wrote:
> I have fixes for no. 1 and 2, patches here:
> https://lists.launchpad.net/kicad-developers/msg34009.html
> and here:
> https://bugs.launchpad.net/kicad/+bug/1743890/comments/6
>
> In case of no. 3 tooltip says "Show footprint text on board's front", so
> it's not really a bug.
>

[Andrzej Wolski (awolski)]

Patch in an attachment.

[Andrzej Wolski (awolski)]

After those changes:

https://git.launchpad.net/kicad/commit/?id=370232f70dd96639ee5e2daac747850bda50eb8d
https://git.launchpad.net/kicad/commit/?id=4c19606eb7aece70eb0b601ae0d0b52b4a98948d
https://git.launchpad.net/kicad/commit/?id=9a3ea1d53cf682fe19513b417e6cf5f1c5ce944a

I think this bug can be closed now?

[Wayne Stambaugh (stambaughw)]

I agree. If the bug submitter is not satisfied with the changes, feel free to reopen this bug report with the specific behavior that you still feel is broken.