Edit Environment variable: lower-case letters not visible

Bug #1747653 reported by simski on 2018-02-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Jeff Young

Bug Description

inpact: confusing.

when starting to type the name of the variable, no typing is visible/no reaction from interface. only when caps are used type is visible.

suggestion: show wrong chars in red. No visible feedback is confusing. or translate to caps automatically, ignoring spaces and other wrong chars

kicad nightly:

Application: kicad
Version: no-vcs-found-fe62760~61~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.13.0-32-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

summary: - Edit Environment variable: smaal letters not visible/translated
+ Edit Environment variable: small letters not visible
Wayne Stambaugh (stambaughw) wrote :

You should hear a beep when typing invalid characters in to the edit control unless your sound is off. I've never seen a text entry show invalid characters while your typing. I don't think it's a good idea to change the behavior to show red invalid characters while typing so this is unlikely to get fixed.

Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
Jeff Young (jeyjey) wrote :

We should convert this to an edit-in-place table (and then capitalise the first column automatically.

summary: - Edit Environment variable: small letters not visible
+ Edit Environment variable: lower-case letters not visible
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
milestone: none → 6.0.0-rc1
Jeff Young (jeyjey) on 2018-03-08
Changed in kicad:
status: Triaged → In Progress

That's the way it was originally designed and is my preference. It was
changed because the original grid editing features were not completed
and apparently was confusing users.

On 3/6/2018 4:59 PM, Jeff Young wrote:
> We should convert this to an edit-in-place table (and then capitalise
> the first column automatically.
>
> ** Summary changed:
>
> - Edit Environment variable: small letters not visible
> + Edit Environment variable: lower-case letters not visible
>
> ** Changed in: kicad
> Assignee: (unassigned) => Jeff Young (jeyjey)
>
> ** Changed in: kicad
> Milestone: None => 6.0.0-rc1
>

Wayne Stambaugh (stambaughw) wrote :

@Jeff, I believe technically we can use lower case environment variables. The reason I didn't allow them is because I'm not sure if case sensitivity is supported the same way on all platforms (does Foo == foo?) so I took the easy way out and forced all upper case. If you attempt to type a digit as the first character, this will get suppressed as well (unless someone changed the validator) so you need to handle that case as well because environment variables cannot begin with a digit.

simski (simski) wrote :

+1 for comment #3.

There is a global unix convention to use only caps for global environmental variables, so allowing lowercase will blur this convention, but automagically convert lowercase to uppercase is a neat solution.

Wayne Stambaugh (stambaughw) wrote :

I'm fine with converting upper to lower case if you don't want to go
through the effort of verifying that there are not any platform case
sensitivity issues.

On 3/8/2018 12:10 PM, simski wrote:
> +1 for comment #3.
>
> There is a global unix convention to use only caps for global
> environmental variables, so allowing lowercase will blur this
> convention, but automagically convert lowercase to uppercase is a neat
> solution.
>

Jeff Young (jeyjey) wrote :

I went with convert-to-upper-case.

The first-character-checking was a bit more involved because of a bug in wxWidgets -- but since it affects all wxGrids with textCtrl validators I developed a workaround for it too.

The main grid editors in 5.0 don't use validators, so I'll leave the workaround in 6.0 along with the rest of this.

simski (simski) wrote :

\o/ hurray! nice work! what is the private branch?

Jeff Young (jeyjey) wrote :

See link in comment #9.

If you want to try out that branch, I'd also appreciate feedback on the Symbol Properties dialog ('e'), the Pin Table dialog, and the Edit Symbol Fields dialog (spreadsheet icon in top toolbar).

simski (simski) wrote :

Hmm. I have no experience in compiling this git. have to look into this. now cloning... if i compile this repo, will it mess up my settings of the js reynaud version im currently running. ie are things changed in the settings files?

Jeff Young (jeyjey) wrote :

Settings files should be the same. Best to back them up, though, just in case.

Jeff Young (jeyjey) on 2018-06-23
Changed in kicad:
milestone: 6.0.0-rc1 → 5.1.0
Jeff Young (jeyjey) on 2018-07-17
Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers