Application task bar title: project name

[Timothée Manaud]

Application task bar title don't show the project name first but instead the application such as:
[(icon)Pcbnew -- /home/user/project/my_blinker.kic...]
(note the filename cut as the title is too long)

On desktop, most application display filename first, and application second, such:
[(icon)my_blinker -- Pcbnew]
-note you can skip the folder and extension as there is no way to display the full path here)

[Nick Østergaard (nickoe)]

Please add version information and a screenshot.

[Timothée Manaud (timothee)]

Application: kicad
Version: no-vcs-found-bf44d39~61~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.13.0-26-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Daniel Walter (fordprfkt)]

I have changed the order of the file name and the application title for Kicad, PCBNew, EESchema, Gerbview and the footprint editor

[Jeff Young (jeyjey)]

@Daniel, a couple of comments on your patch:

To be consistent you should use wxT( "..." ) instead of L"..." for strings that don't need translating. Any string that does need translating must be inside _( "..." ). (This also obviates the need for a wxString constructor.)

Also, the translation framework we use can't handle non-ascii characters. So if you do need to use them you need to put them in wxT( "..." ) macros rather than _( "..." ). Generally speaking, though, we try to avoid them as cross-platform support can also be iffy.

And you're missing spaces after parenthesis in a couple of places. (Yes, it's an odd formatting standard, but it keeps things consistent.)

[Daniel Walter (fordprfkt)]

Hello Jeff, thank you for the Review! I'll fix it and submit a new patch.

Daniel

Jeff Young <email address hidden> schrieb am Mo., 28. Mai 2018, 14:25:

> @Daniel, a couple of comments on your patch:
>
> To be consistent you should use wxT( "..." ) instead of L"..." for
> strings that don't need translating. Any string that does need
> translating must be inside _( "..." ). (This also obviates the need for
> a wxString constructor.)
>
> Also, the translation framework we use can't handle non-ascii
> characters. So if you do need to use them you need to put them in wxT(
> "..." ) macros rather than _( "..." ). Generally speaking, though, we
> try to avoid them as cross-platform support can also be iffy.
>
> And you're missing spaces after parenthesis in a couple of places.
> (Yes, it's an odd formatting standard, but it keeps things consistent.)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1745607
>
> Title:
> Application task bar title: project name
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> Application task bar title don't show the project name first but instead
> the application such as:
> [(icon)Pcbnew -- /home/user/project/my_blinker.kic...]
> (note the filename cut as the title is too long)
>
> On desktop, most application display filename first, and application
> second, such:
> [(icon)my_blinker -- Pcbnew]
> -note you can skip the folder and extension as there is no way to
> display the full path here)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1745607/+subscriptions
>

[Daniel Walter (fordprfkt)]

Fixed review findings: Usage of non-ascii characters, used string constructor, code formatting

[Jeff Young (jeyjey)]

@Daniel, the source tree is now open for 6.0. Could you rebase your two patches so I can apply them? Thanks, Jeff.

[Daniel Walter (fordprfkt)]

I tried to rebase the .patch files but apparently the HEAD changed so much, git is unable to apply them. Looks like i have to redo the changes

[Timothée Manaud (timothee)]

Hi Daniel, any update about this patch for V6.0?
Thanks a lot for your work!

[Franck78 (fbourdonnec)]

The probably correct way to handle this 'simple' (it is never simple) problem is erasing all the stuff and just have a single utility function that returns the correct string, always good.

string getwindowtitle (pgm, path, file, modified)

Version is a fully superfluous information. 0.001% users are dev that may sometime work on several instance of Kicad and need to see it.
Adding it for not 'release' version is more than enough

#ifnded RELEASE
  +git-blahblah
#endif

[KiCad Janitor (kicad-janitor)]

KiCad bug tracker has moved to Gitlab. This report is now available here: https://gitlab.com/kicad/code/kicad/-/issues/2096