Remove layer name max char length

Bug #1745587 reported by Timothée Manaud on 2018-01-26
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Jeff Young

Bug Description

In Pcbnew, Layer Setup, one can change the copper layer name. (BTW why no other layers?)
But the layer name is limited to 20 char, is there a good reason? As I would like explicit naming in my project.

Version:
Application: kicad
Version: no-vcs-found-bf44d39~61~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.13.0-26-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON

Copper layer names are intended to be renamed by net names, when they are planes.
(20 chars for a net name is really is really a long net name)
A to long name creates issues to be shown in the layer manager.
Renaming other layers has no sense, because they are dedicated layers.

but what is really the meaning of:
"I would like explicit naming in my project"

Changed in kicad:
status: New → Incomplete
Timothée Manaud (timothee) wrote :

I would like long naming, especialy non copper layer: they are not dedicated as User1, User2, Cmts, Dwgs. To me it looks like I can do what I want with theses 4 layers, so renaming them to:
"plastic_case_without_ribs"
"brass_insert_injection_molding"
"test_fixture_top_push_pin"
"test_fixture_bottom_test_nail"

Makes sense, as when exporting, the layer name is in the filename.

Wayne Stambaugh (stambaughw) wrote :

AFAIK there is no limit in the board file format for the length layer names. If users want to use very long layer names then they can live with the consequences of making a mess of how their board is displayed. I don't think we should arbitrarily limit this unless there is some technical reason.

Changed in kicad:
status: Incomplete → Opinion
status: Opinion → Triaged
importance: Undecided → Wishlist
Timothée Manaud (timothee) wrote :

Hi Wayne, you are right there is no limit to to layer length, but there is a limit on the "Layers Setup" dialog.
In the file:
pcbnew/dialogs/dialog_layers_setup_base.fbp
This property prevent from inputing anything longer that 20 char:
<property name="maxlength">20</property>

Jeff Young (jeyjey) on 2018-07-05
summary: - Layer name max char length
+ Remove layer name max char length
Jeff Young (jeyjey) on 2018-09-29
Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
milestone: none → 5.1.0
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision b49ca04355924fad99db0f40c755e48b43f93f51
https://git.launchpad.net/kicad/patch/?id=b49ca04355924fad99db0f40c755e48b43f93f51

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers