pcbnew: SMD pad visibility affects printing

[Sergey A. Borshch]

enabling/disabling layers visibility in layers manager toolbar enables/disables some elements in print output. It is not correct, as printing setup has it's own layers selection toolbar.

how to reproduce:
create pcb layout with at least one footprint and track on F.Cu layer.
press Print icon and select F.Cu layer in Print dialog.
press Preview button: You'll see pads and track in preview. So far all is OK

close print dialog
disable F.Cu layer in layers manager
open Print dialog, check that F.Cu layer printing is still enabled
press Preview button: Only pads are seen on preview and no tracks.
similarly, Pads front on Render tab enables/disables pads in print output.

Layers manager should affect only displayed items and not affect printed, as print dialog has it's own layers selector.

Version info:

Application: pcbnew
Version: (2018-01-19 revision 388d07a)-master, release build
Libraries:
    wxWidgets 3.0.2
Platform: Linux 4.4.0-104-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision c702646c252e1b7225a85624aafa79d9919ebb0f
https://git.launchpad.net/kicad/patch/?id=c702646c252e1b7225a85624aafa79d9919ebb0f

[Sergey A. Borshch (sb-sf)]

Fix incomplete. Pads and Text visibility in Layers manager Render tab still affects printing output.

[Jeff Young (jeyjey)]

Through-hole pads are handled correctly; SMD pads are not.

[Jeff Young (jeyjey)]

Module text was also broken. Patch fixes both.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6b12fef288c4307e233e43d85914e5b09a757160
https://git.launchpad.net/kicad/patch/?id=6b12fef288c4307e233e43d85914e5b09a757160

[Maciej Suminski (orsonmmz)]

Jeff,

Should not the line:

  Pcb->SetElementVisibility( LAYER_PAD_FR, LAYER_MOD_TEXT_BK );

read:

  Pcb->SetElementVisibility( LAYER_MOD_TEXT_BK, true );

Looks to me like a copy-paste mistake, but I might not have understood the real intention here.

[Jeff Young (jeyjey)]

@Orson, you are indeed correct. It is easier for you to fix directly or should I upload another patch?

[Maciej Suminski (orsonmmz)]

Jeff, I have fixed it directly. Thank you for quick confirmation.