symbol library editor ask about save on exit

Bug #1744724 reported by Nicholas Savenlid
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Unassigned

Bug Description

Even tough i have pressed save symbol and/or save library and all save buttons are grayed out it still ask my if I want to save the lib(s) on exit.

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

Application: kicad
Version: (2018-01-21 revision 6b9866de8)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

The toolbar buttons correspond to the currently opened part/library. Most likely you have modified another library and have not saved the changes, please verify.

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

I launched from schematics , right clicking a symbol and properties / edit with symbol library

So thats the way the lib was opened / invoked.
Then i did duplicate, renamed, edit , exit

will verify next time.

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

confirmed

I dont open any other lib than 1 lib / target lib

launch from schematic via properties / edit with library editor

duplicate / rename / edit / save / exit

regardless the amount of save buttons i push, a save pop-up appears

Revision history for this message
Jeff Young (jeyjey) wrote :

I can't reproduce this.

Application: kicad
Version: (2018-01-22 revision 618af8738)-master, debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.3.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.66.0
    Curl: 7.57.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=OFF
    KICAD_SPICE=ON

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

Its still there
1: open a lib
2: duplicate a part
3: rename / edit
4: save part button
5 save lib button
6: exit

it ask you if you want to save the lib.
rock solid, every time.

Application: kicad
Version: (2018-01-21 revision 6b9866de8)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

Revision history for this message
Jeff Young (jeyjey) wrote :

@Nicholas, I still can't reproduce it. Can you be more specific about your steps?

I assume step 1 is still:
1a: Open schematic
1b: Right click on symbol; chose Edit

How are you duplicating? Is that through right-clicking on the part in the component tree? Are you duplicating the root part or an alias?

How are you renaming? Pressing E over the value field on the canvas? Right click on value field?

Steps 4 and 5 seem pretty self-explanatory.

What about 6? Is that clicking the libedit window close box? Or exiting the application?

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote : Re: [Bug 1744724] Re: symbol library editor ask about save on exit

I can send a video next time i do it.
will do later today

2018-01-23 12:22 GMT+01:00 Jeff Young <email address hidden>:

> @Nicholas, I still can't reproduce it. Can you be more specific about
> your steps?
>
> I assume step 1 is still:
> 1a: Open schematic
> 1b: Right click on symbol; chose Edit
>
> How are you duplicating? Is that through right-clicking on the part in
> the component tree? Are you duplicating the root part or an alias?
>
> How are you renaming? Pressing E over the value field on the canvas?
> Right click on value field?
>
> Steps 4 and 5 seem pretty self-explanatory.
>
> What about 6? Is that clicking the libedit window close box? Or
> exiting the application?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1744724
>
> Title:
> symbol library editor ask about save on exit
>
> Status in KiCad:
> New
>
> Bug description:
> Even tough i have pressed save symbol and/or save library and all save
> buttons are grayed out it still ask my if I want to save the lib(s) on
> exit.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1744724/+subscriptions
>

Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

video

some paus while i looked for new-part mo
but at the end shows the problem.

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

Amazing.. I launched cbf433fe on two machines next to each other and performed the same steps as shown on the video. On Linux it works as expected (i.e. library is saved and there are no dialogs), on Windows 7 it behaves as on the video. The joy of multiplatform development erupts again.

Nicholas, thank you for the video, it made the steps very clear.

Changed in kicad:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Jeff Young (jeyjey) wrote :

Huh, that's not one I would have guessed would end up being platform-dependent.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 351a8d72b8deb430ab70333f27ef68bbf413d1e1
https://git.launchpad.net/kicad/patch/?id=351a8d72b8deb430ab70333f27ef68bbf413d1e1

Changed in kicad:
status: Confirmed → Fix Committed
Revision history for this message
Nicholas Savenlid (nicholas-z) wrote :

problem still alive.

video can be provided on request.

Application: kicad
Version: (2018-02-15 revision 29b28de31)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.