schematic libedit: "Delete All" button in Properties-dialog, | Aliases-tab does not work

[Jan Krieger]

I try to delete all ALIASes of a symbol in libedit in two different ways (all in the ALIAS-tab of the properties-dialog):
1. select a single ALIAS and click delete ==> ALIAS is deleted
2. click "Delete All" ==> ALIASes vanish. After clicking OK (and closing the dialog) they have not been deleted.

My version: Win64-nightly kicad-r9237.6b9866de8-x86_64 from 21-Jan-2018

[Jeff Young (jeyjey)]

There are (at least) two bugs here: deleting a single alias does it when the delete button is clicked -- it does *not* wait for OK. So if you Cancel the dialog, your alias is still gone.

[Jeff Young (jeyjey)]

The code looked like a merge gone awry. There were at least two competing strategies on how to handle the aliases list, and they weren't getting along well.

I fixed the two bugs, and normalised the alias list. It now displays only the aliases (not the name of the root), and states what it is displaying at the top when the edited part is an alias. This brings the aliases list in line with the user model (where they're presented as aliases *of* the root, not a collection *including* the root).

[KiCad Janitor (kicad-janitor)]

Fixed in revision 76885169c4024eed14fa2e053e1b00357005616c
https://git.launchpad.net/kicad/patch/?id=76885169c4024eed14fa2e053e1b00357005616c

[Maciej Suminski (orsonmmz)]

Thank you Jeff, I have just verified and pushed your patch.