Selection box sometimes gets fat

[Andrzej Wolski]

Selection box outline sometimes gets fatter (like on image in attachment) or have other artifacts (missing one edge or one edge have different width).
Observed multiple times on nightly builds for at least 6 months.
I do not have a way to reliably reproduce this.

Application: pcbnew
Version: (2018-01-14 revision 2f6e0117f)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 495c4125f9cfc4d02646a5c12ee575d958faa7d0
https://git.launchpad.net/kicad/patch/?id=495c4125f9cfc4d02646a5c12ee575d958faa7d0

[KiCad Janitor (kicad-janitor)]

Fixed in revision 74d47d8173f55f75d0534e5a02c74695f8e5d74b
https://git.launchpad.net/kicad/patch/?id=74d47d8173f55f75d0534e5a02c74695f8e5d74b

[Andrzej Wolski (awolski)]

The second patch causes rectangular pads (and other rect objects) to have wrong outline width.
So see this:
1. Zoom out
2. Switch pads to be shown in outline mode
3. Zoom in. All rectangular pads will have fat outlines.

It also causes selection box outline to be sometimes 2 pixels wide and sometimes 1.

Image illustrating both problems in an attachment.

I think this patch should be reverted.

[jean-pierre charras (jp-charras)]

I reverted this second patch, as it breaks any rectangle drawing in outline mode.

Moreover, the first patch should have fixed this issue.