pcbnew crash when refill zone

[Jean-Samuel Reynaud]

When opening attached kicad_pcb, I got a crash we trying to refill zone/area (b hotkey).

Look to be the triangulate algo that produce a triangle with "null pointer" in vector "neighbors_".
OppositePoint is called on one of this neighbor. "this" object is null:
This result a segmentation fault.

To reproduce this bug:

start pcbnew
open "crash.kicad_pcb" (attached)
hit "B" (zones refill all)
=> resulting a crash

Application: pcbnew
Version: no-vcs-found-1955f25~61~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.10.0-40-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Oivind Toien (otoien)]

If I add another footprint in crash.pcb that also with a ground net pin (SO-8) it will still crash. However if I then delete the original footprint in crash.pcb, fill zone will no longer crash (attached file). There is something about that footprint in crash.pcb that messes up fill zones. None of my own boards crash when using fill zones.

Application: kicad
Version: (2017-12-11 revision b395b55a2)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Jiri Kerestes (nephirus)]

I am also experiencing crashes related to filled zones. Opening a .kicad_pcb file with filled zones causes pcbnew to segfault. With zones manually removed, it starts just fine.

[KiCad Janitor (kicad-janitor)]

Fixed in revision eed924fe45e85707a3032466c76fd2289881c325
https://git.launchpad.net/kicad/patch/?id=eed924fe45e85707a3032466c76fd2289881c325

[Oivind Toien (otoien)]

Thanks,I can confirm fix on crash.kicad_pcb in tonights Windows nightly (2017-12-14 revision b47a06e42)