Change in design rule not picked up unless tab out of field

[Jeff Young]

1) Design Rules > Design Rules > click on Global Design Rules tab
2) change one of the track widths, but DO NOT tab out of the text box or click elsewhere
3) hit return to apply the changes
4) changes not applied

5) Design Rules > Design Rules > click on Global Design Rules tab
6) change one of the track widths, and tab out of the text box
7) hit return to apply the changes
8) changes correctly applied

Application: pcbnew
Version: 4.0.7 release build
wxWidgets: Version 3.0.2 (debug,UTF-8,compiler with C++ ABI 1002,GCC 4.2.1,STL containers,compatible with 2.8)
Platform: Mac OS X (Darwin 17.2.0 x86_64), 64 bit, Little endian, wxMac
Boost version: 1.57.0
Curl version: libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
         USE_WX_GRAPHICS_CONTEXT=ON
         USE_WX_OVERLAY=ON
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

[Nick Østergaard (nickoe)]

Please retest this on nightly.

[Jeff Young (jeyjey)]

On nightly hitting return goes to the next track width text-box, but clicking "OK" with the mouse before tabbing, returning, or clicking out of the edited field still fails.

Tested on:
Application: kicad
Version: (2017-12-06 revision ee56e21)-master, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.2 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.61.0
    Curl: 7.43.0
    Compiler: Clang 7.3.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Oivind Toien (otoien)]

I cannot reproduce this on the Windows nightly, perhaps Mac OS X specific bug?

Application: kicad
Version: (2017-12-05 revision cdad02336)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

If it's Mac-only, then I expect other platforms are relying on the serendipity of event order processing.

Patch attached.

[Jeff Young (jeyjey)]

Replaced diff-style patch with format-patch-style patch.

[Wayne Stambaugh (stambaughw)]

I don't have access to a mac but your patch didn't change the behavior on windows so I merged your patch into the master branch. Thank you for your contribution to KiCad

[KiCad Janitor (kicad-janitor)]

Fixed in revision 27a55c5cd4e9e881cc75aa1c5705debac37c7618
https://git.launchpad.net/kicad/patch/?id=27a55c5cd4e9e881cc75aa1c5705debac37c7618