Place a 'Grid Origin' will not trigger a change in the pcb

Bug #1730371 reported by m
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Unassigned

Bug Description

Place a 'Grid Origin' will not trigger a change in the pcb; then the 'Save' button will not be enabled by this action.
This behavior is present both on stable and developing release.

Tags: pcbnew starter
Changed in kicad:
status: New → Triaged
importance: Undecided → Low
tags: added: starter
Revision history for this message
m (easyw) wrote :

the attached patch will trigger Save button for 'Grid Origin' in Legacy canvas, as it is done for the 'Drill and Place Offset'.
ATM in GAL both action will not trigger the document to be changed.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Since you did not provide a patch using `git am`, I do not have your name and email to set the author information for the commit. If you don't want to provide this information than I will just commit it with me as the author. In the future, please use `git am` to create patches and provide a proper commit message. KiCad devs are busy and this just creates more work for them.

Revision history for this message
m (easyw) wrote :

never used git am, so I need to learn it for the next patch...

my reference, if you need them, are:
<email address hidden>
Maurice

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1730371] Re: Place a 'Grid Origin' will not trigger a change in the pcb

Sorry about the confusion. You need to use `git format-patch` to create
patch submissions. KiCad devs would then use `git am` to apply the patch.

On 11/10/2017 4:40 AM, m wrote:
> never used git am, so I need to learn it for the next patch...
>
> my reference, if you need them, are:
> <email address hidden>
> Maurice
>

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 5e5abc52416c44b5b5b9fb9daf5e0cff1be5a0ce
https://git.launchpad.net/kicad/patch/?id=5e5abc52416c44b5b5b9fb9daf5e0cff1be5a0ce

Changed in kicad:
status: Triaged → Fix Committed
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Maurice, I merged your patch in the development branch. Thank you for your contribution to KiCad.

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.