Color picker issues on macOS

Bug #1718389 reported by Seppe Stas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Unassigned

Bug Description

The new color picker introduced in [5f4599fb56da4dd748845ab10abec02961d477f3](https://git.launchpad.net/kicad/patch/?id=5f4599fb56da4dd748845ab10abec02961d477f3) does not work correctly on macOS. The controls seem to work, but the visual representation (color wheel) seems to be missing. See attached screenshot.

Produced on KiCad at 4122aa1c0 on macOS 10.12.6 (16G29)

Revision history for this message
Seppe Stas (seppestas) wrote :
Seppe Stas (seppestas)
description: updated
Revision history for this message
Jon Evans (craftyjon) wrote :

Confirmed on my 10.12 machine

Changed in kicad:
status: New → Confirmed
Seppe Stas (seppestas)
tags: added: gerbview
Revision history for this message
jean-pierre charras (jp-charras) wrote :

Hi Jon,
I am not able to debug OSX applications, and I do not see anything in code that can explain this issue.

Could you have a look into this problem.
Thanks.

Revision history for this message
Bernhard Stegmaier (stegmaier) wrote :

Same for me, also on 10.12.
Also doesn't work with a current wxWidgets master.

Revision history for this message
Seppe Stas (seppestas) wrote :

I narrowed down the issue to `createRGBBitmap` (and probably also `createHSVBitmap`).

When setting the background of `bitmapDC` in `createRGBBitmap` to red I get the attached result.

Maybe changing the origin doesn't work on macOS?

Revision history for this message
Seppe Stas (seppestas) wrote :

Mmmh, the alpha channel of a `KIGFX::COLOR4D` initializes to 0... The color pickers shouldn't work on any platform. I guess it was tested on a platform that does not support colors with alpha channels in `wxBitmap` (I'm guessing Windows).

Anyhow, setting it to 1 seems to work. Will send patch to mailing list.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 5aeb6129ca8c83919576f3e090b7ea2430c6b1b0
https://git.launchpad.net/kicad/patch/?id=5aeb6129ca8c83919576f3e090b7ea2430c6b1b0

Changed in kicad:
status: Confirmed → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.