Creating new project from template overwrite existing files

Bug #1713951 reported by Roberto
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
High
Wayne Stambaugh

Bug Description

I am using kicad with Windows 10.
When I create a new project from a template and select an existing folder,
the file in that directory are overwrite with the files from template without
a warning message

Sorry I can't paste information as I'm using smartphone, anyway
Version is 2017-04-24 revision 50716c901

Tags: 4.0.7
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

This bug affects both the development branch and 4.0.7.

Changed in kicad:
status: New → Confirmed
Changed in kicad:
importance: Undecided → High
assignee: nobody → Wayne Stambaugh (stambaughw)
Revision history for this message
Roberto (roberto-castellani35) wrote :

Dear Wayne thank you for your attention.
May I ask you also to consider the opportunity to create a new folder when creating a new project form a template. Now you can just select an existing one. It works fine when you create a new project. It asks if you want to create new folder, as the select one is not empy. Many thanks for your time

Revision history for this message
Roberto (roberto-castellani35) wrote :

Correction:
.......a new project from template. ....
Sorry

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Roberto, I see your using windows 10 so you should be able to use the system file dialog to add new folders if you want to. I don't think it makes sense to add a separate project folder creation dialog.

tags: added: 4.0.7
Revision history for this message
Roberto (roberto-castellani35) wrote :

Thank for your answer. In fact I can use windows to create a new folder, it is not a problem. My idea was to have a similar behaviour in the two creation of project: with and without template. I think this can confuse new kicad's user.
Looking in source code,file prjconfig.cpp , I saw function ONLOADPROJECT included instructions to create also from template, then function ONCREATEPROJECTFROMTEMPLAYE does the same but in a diffetent way. I was wandering why.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I just push the fix for this to the master branch. Please test it when you get a chance and let me know if you find any issues. It ended up being a much bigger code change than I would have expected.

Revision history for this message
Roberto (roberto-castellani35) wrote :

Thank you for the work.
Do I find the compiled Windows version in http://downloads.kicad-pcb.org/windows/nightly/

Or is somewhere else. I can't compile from source.
I really looking forward to try it.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1713951] Re: Creating new project from template overwrite existing files

On 8/31/2017 1:47 PM, Roberto wrote:
> Thank you for the work.
> Do I find the compiled Windows version in http://downloads.kicad-pcb.org/windows/nightly/

Yes, yhis is where you will find the latest nightly build. It may take
a day or so for the builders to catch up to the repo before this change
is available.

>
> Or is somewhere else. I can't compile from source.
> I really looking forward to try it.
>

Revision history for this message
Roberto (roberto-castellani35) wrote :

I just tried.
Now it doesn't overwite existing files. Thats PERFECT.
But I found a bug:the "new project" doesn't create the .pro file and the project tree view is not update.
Minor problem:in the Italian translation "Do Not Overwite" is "Sono sovrascrivere" which is wrong. Should be "Non sovrascrivere"

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I believe this is all fixed now in the development branch. If not please report back so we can get it fixed for the stable 5 release.

Changed in kicad:
status: Confirmed → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.