PNS router length tuning does not match full length (inc. pad to die)

[Andrey Fedorushkov]

PNS router length tuning - not check length pad in die

Tuning length single trace and diff trace not used length pad in die.
Tuner calculate length only on board.

Application: kicad
Version: no-vcs-found-(2017-aug-18 git:d25fdfdb8)-master, release build
Libraries: wxWidgets 3.0.3
           libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.7.0 nghttp2/1.9.2
Platform: Linux 4.9.40-desktop-1.mga6 x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
Curl: 7.54.1
KiCad - Compiler: GCC 5.4.0 with C++ ABI 1009
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  KICAD_SCRIPTING_ACTION_MENU=OFF
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_OCE=OFF

[Andrey Fedorushkov (faa)]

This patch add check or uncheck pad length in die when tuning length single or diff track in PNS-router.
Autor Roman Bashkov.

[Wayne Stambaugh (stambaughw)]

This patch seems reasonable to me except for a few coding policy violation. Would our resident tuned length router expert care to weigh in on this?

[Tomasz Wlostowski (twlostow)]

Hi Andrey,

Please do not put any Kicad-specific code in any router file except pns_kicad_iface.[cpp,h] or length_tuner_tool.[cpp,h]

m_startItemLenToDie = 0;
if( m_startItem )
{
    TRACK *track = dyn_cast<TRACK*>( m_startItem->Parent() );
    if( track )
    {
        m_startItemLenToDie = track->GetLengthPadToDie();
    }
}

The pad to die length is a pad's attribute and hence can be a property of PNS_SOLID. Remember to add synchronization of this property in PNS_KICAD_IFACE::syncWorld()

Tom

[Madeliene Kattman (katm)]

Hi,

Just wanted to note that using the current build, this patch wasn't applied and the issue remains open. Is there any chance of seeing this committed sooner rather than later? We're about start a whole bunch of length matching, and having the router take pad to die lengths in to consideration when length matching would save a tremendous amount of time.

Alternatively, is it safe to apply this patch as-is without causing problems later on?

---

Application: Pcbnew
Version: (5.1.0-1512-gdd938b02d), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1b zlib/1.2.11 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.1.1) libssh2/1.8.1 nghttp2/1.36.0
Platform: Linux 5.0.4-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 4178cf7f3670df1b91953d0012de2c32e084144d
https://git.launchpad.net/kicad/patch/?id=4178cf7f3670df1b91953d0012de2c32e084144d

[Seth Hillbrand (sethh)]

If this shakes out in 6.0 with no issues, we'll consider moving it to 5.1.6 as well.

[Seth Hillbrand (sethh)]

If cherry-picked, bring lp:1851251 with as well.