gerberviewer export to pcbnew error

[Mauricio Martins De Carvalho]

On Kicad versions > 4.0.2, the gerberviewer "export to pcbnew" has an error on the layer matching window. That is, the small window which allows matching the imported layer to the exported layer is not displayed properly. All fields are on top of each other on a single line, making it impossible to select the layers.

[Nick Østergaard (nickoe)]

Can you provide a screenshot? Can you explicitly state if this affects the nightlies?

[Mauricio Martins De Carvalho (mauriciocarvalho)]

Ok, seems like it works on build 4.0.6 when I use apt-get. Last night I tried compiling 4.0.6 from scratch and I had the error reported above. I re-installed it from the nightly repository and I still have the error above. Please find in the attachment the screen shot.

[Jeff Young (jeyjey)]

Once you get too many layers for the dialog to show cleanly, the formatting does indeed go all to hell.

[jean-pierre charras (jp-charras)]

@Jeff,

I don't think removing lasted size used for dialog is good, for a few reasons:
- In Kicad, all dialogs use the last size when reopened.
- All dialogs can be resized. It should fix this issue.
- In any case the dialog has a min size recalculated each time.

I have no issue on Windows in current kicad version (master branch).

So if the issue still exists on some platforms, it is due to an other (not fixed) problem.

[Jeff Young (jeyjey)]

@JP, in the end that patch exceeded my hack-o-meeter alarm setting, so I'm going to withdraw it.

However, we do have a real problem with DIALOG_SHIMs resizing. It does it through routines which ignore the minimum size requirements (at least on some platforms) and so messes up anything which is dynamically sized (like this dialog, or the Plot dialog with different SVG/DXF/etc. settings, or the Exchange Footprints dialog with update vs. change sections, etc.)

There are two cases: the dialog has already been opened with the current layout, in which case we saved the size when it was closed and the saved size will have no effect; or the dialog has just been created / layed-out and we should set the location but only adjust the size if the saved size is larger.

[Wayne Stambaugh (stambaughw)]

@Jeff, did you mean to attach your patch to this bug report? I did not
see the fixes statement to automatically close the bug report in the patch.

On 2/18/2018 8:16 PM, Jeff Young wrote:
> ** Patch added: "0008-Don-t-size-GerbView-Layer-Mapping-dialog-to-last-use.patch"
> https://bugs.launchpad.net/kicad/+bug/1692442/+attachment/5058028/+files/0008-Don-t-size-GerbView-Layer-Mapping-dialog-to-last-use.patch
>

[Jeff Young (jeyjey)]

@Wayne, it should fix a bunch, but I didn't find any others logged and then forgot to add even this one.

Patch updated with fixes statement.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 5c6b19c55dc61f73f9473ce0e11eb15979d5235f
https://git.launchpad.net/kicad/patch/?id=5c6b19c55dc61f73f9473ce0e11eb15979d5235f

[Wayne Stambaugh (stambaughw)]

Patch merged. Thanks.