warning about misleading indentation

Bug #1687223 reported by Simon Richter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Invalid
Undecided
Unassigned

Bug Description

During compiling, I get

pcbnew/edit.cpp: In member function 'void PCB_EDIT_FRAME::OnSelectTool(wxCommandEvent&)':
/home/geier/OSS/kicad/pcbnew/edit.cpp:1446:9: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
         else
         ^~~~
pcbnew/edit.cpp:1448:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
             Compile_Ratsnest( &dc, true );
             ^~~~~~~~~~~~~~~~

This should be trivial to resolve if you know whether the correct behaviour is to compile the ratsnest in this case or not.

Tags: pcbnew
Revision history for this message
jean-pierre charras (jp-charras) wrote :

I do not understand this report:
In edit.cpp:
* The current code is correct around line 1446.
* Line 1446 is "case ID_TRACK_BUTT:" not a "else" token.
* Line 1448 is not "Compile_Ratsnest( &dc, true );"

Revision history for this message
Simon Richter (sjr) wrote :

Argh, that is in a commit I accidentally pulled in while testing the connectivity rework branch.

Changed in kicad:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.