KiCad shoud install libraries to lib64 on 64-bit Linux systems

[Vlad Ivanov]

KiCad should take into account LIB_SUFFIX CMake definition passed by some build environments. KiCad daily builds in Fedora COPR repo fail because of this:

https://copr-be.cloud.fedoraproject.org/results/%40kicad/kicad/fedora-26-x86_64/00536162-kicad/build.log.gz

Current stable KiCad package in Fedora replaces the hardcoded path during build preparation:

sed -i "s|KICAD_PLUGINS lib/kicad/plugins|KICAD_PLUGINS %{_lib}/kicad/plugins|" CMakeLists.txt

I have attached a patch that should fix the issue.

[Nick Østergaard (nickoe)]

Hmm, what about using https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html

Which includes CMAKE_INSTALL_LIBDIR, maybe this is a better way without using a "custom" and undocumented variable when it seems that an official cmake method is available?

(I have not attempted this, I was just wondering if cmake didn't have some provisions for this already)

[Wayne Stambaugh (stambaughw)]

On 4/5/2017 6:37 AM, Nick Østergaard wrote:
> Hmm, what about using
> https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html
>
> Which includes CMAKE_INSTALL_LIBDIR, maybe this is a better way without
> using a "custom" and undocumented variable when it seems that an
> official cmake method is available?
>
> (I have not attempted this, I was just wondering if cmake didn't have
> some provisions for this already)
>

It probably does and this would be my preference. Someone please test
this and confirm before we merge this patch and have yet another
non-cmake way of installing targets in our build config.

[Vlad Ivanov (vlad-mbx)]

I have actually tested GNUInstallDirs before resorting to this solution.
On my system (Fedora 25) LIBDIR is just lib, without 64 — I don't know why.

LIB_PREFIX is, however, defined in default RPM macros, and thus automatically defined when building RPMs on x86_64 systems.

https://fedoraproject.org/wiki/Packaging:Cmake#RPM_Macros

[Vlad Ivanov (vlad-mbx)]

I just checked again and it turns out I had to clean the build directory in order to make GNUInstallDirs work. Therefore, my previous comment is invalid — sorry about that. I'll update the patch.

[Vlad Ivanov (vlad-mbx)]

I have updated the patch.

[Wayne Stambaugh (stambaughw)]

Can some of our linux devs who use other distros please test this patch before I commit it. It doesn't appear to break anything on windows msys2 builds and it looks like it wont effect osx builds but I would feel better if we tested it on other linux distros first.

[Nick Østergaard (nickoe)]

I tested this on archlinux, I think this patch should be fine on other linux systems also. I think most systems symlink lib to lib64 on 64-bit systems.

[Wayne Stambaugh (stambaughw)]

I committed this patch to the master archive. Hopefully it doesn't break any linux builds. Thank you for your contribution to KiCad.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1e25c4736233a4971c85189ea1e9faa8f0a36722
https://git.launchpad.net/kicad/patch/?id=1e25c4736233a4971c85189ea1e9faa8f0a36722

[Nick Østergaard (nickoe)]

Thank you, the fedora copr build got green now.