Invalid files written when layers have numeric name

[Chris Pavlina]

If a layer is given a purely numeric name, pcbnew saves a file it can't load. This affects both stable and master. User has declined to make the example file public, but it's trivial to reproduce from scratch.

Application: pcbnew
Version: 4.0.5 release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1010,GCC 6.2.1,wx containers,compatible with 2.8)
Platform: Linux 4.9.11-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.63.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

Application: pcbnew
Version: (2017-02-24 revision c5d3f51af)-master, debug build
Libraries: wxWidgets 3.0.2
           libcurl/7.52.1 OpenSSL/1.0.2k zlib/1.2.11 libpsl/0.17.0 (+libicu/58.2) libssh2/1.8.0
Platform: Linux 4.9.11-1-ARCH x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.63.0
Curl: 7.52.1
KiCad - Compiler: GCC 6.3.1 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=OFF
                  KICAD_SCRIPTING_MODULES=OFF
                  KICAD_SCRIPTING_WXPYTHON=OFF
                  KICAD_SCRIPTING_ACTION_MENU=OFF
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_OCE=ON

[Chris Pavlina (pavlina-chris)]

I think the fix for this should be pushed to the stable branch. I'm not sure if it's too late for 4.0.6 considering at least one zealous packager has already released packages...

[David Pearce (halzia)]

The user forum thread
https://forum.kicad.info/t/error-loading-board-with-numeric-layer-name/5475

[KiCad Janitor (kicad-janitor)]

Fixed in revision 94bef6abd29fc4c603da107eef00fa781161ca76
https://git.launchpad.net/kicad/patch/?id=94bef6abd29fc4c603da107eef00fa781161ca76

[Wayne Stambaugh (stambaughw)]

On 2/24/2017 9:02 PM, Chris Pavlina wrote:
> I think the fix for this should be pushed to the stable branch. I'm not
> sure if it's too late for 4.0.6 considering at least one zealous
> packager has already released packages...
>
> ** Tags added: parser
>

Yep. If someone hadn't pulled the trigger early on a 4.0.6 packages, I
could have forced it into 4.0.6 but I think it's too late for that.
I'll merge it into the next stable 4 release.

[Chris Pavlina (pavlina-chris)]

We could pull it into the imminent release, but rename that release to 4.0.7 so that the versioning doesn't get messed up on the early package release. I don't think it'd delay the release *too* much.

[Wayne Stambaugh (stambaughw)]

On 2/25/2017 11:30 AM, Chris Pavlina wrote:
> We could pull it into the imminent release, but rename that release to
> 4.0.7 so that the versioning doesn't get messed up on the early package
> release. I don't think it'd delay the release *too* much.
>
Ugh! Skipping 4.0.6 will just confuse folks. I'm tempted to just merge
JP's fix and release 4.0.7 in the next few weeks. Maybe some other 4
stable bugs can be fixed in the mean time. I don't think the bug is
critical given that it took over four years to find it.

[jean-pierre charras (jp-charras)]

I have also an other (minor) fix for 4.07 (for a certainly old bug), already committed in master branch.

[Wayne Stambaugh (stambaughw)]

@JP, thank you for fixing this. I just reset the version string on the
4.0 branch for the 4.0.7 release so please feel free to commit any fixes
for the next stable release when you get a chance.

On 2/25/2017 1:09 PM, jean-pierre charras wrote:
> I have also an other (minor) fix for 4.07 (for a certainly old bug),
> already committed in master branch.
>

[David Pearce (halzia)]

This one can wait a few weeks, as the workround of not using a pure numeric name is known.

Somebody commented that 4.0.6 might be the last 4.0.x release, nothing is more certain to flush out ancient bugs