GAL Picker tool doesn't start with cursor or snapping

[John Beard]

The PICKER_TOOL used by several GAL actions for choosing a point has a problem when it first starts, for example, Set Grid Origin and Set Drill Origin.

Although it sets grid snap and cursor on in the PICKER_TOOL::setControls() function, the cursor and snap don't take effect until after the first click.

This is despite the picker tool calling void setControls() before the event loop starts.

One you click once (and the click handler fires once), the next point selection will have both cursor and grid snapping enabled, as originally expected. So, that's a workaround.

This is in contract to actions like DRAWING_TOOL::SetAnchor(), which don't use the PICKER_TOOL, and get the cursor and snapping right away.

[KiCad Janitor (kicad-janitor)]

Fixed in revision b25ded4d90c94f74983a9a6ee54df90fbcf890a4
https://git.launchpad.net/kicad/patch/?id=b25ded4d90c94f74983a9a6ee54df90fbcf890a4