GAL copy/apply/push settings always enabled in menu

[John Beard]

The GAL pad submenu options for copy/apply/push settings are enabled when they shouldn't be.

The commands should be disabled when there are no pads selected.

Apply & Push should be disabled when there is no global settings source pad set up yet.

Bug lp:1663915 is somewhat related as it occurred when the pad push dialog was invoked without a source pad.

[John Beard (john-j-beard)]

Branch https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/pad_menus has a fix for this issue.

[Maciej Suminski (orsonmmz)]

Hi John,

I could not ever enable 'Apply Pad Settings' entry. Seemingly m_Pad_Master does not have its parent set, so PAD_TOOL::hasMasterPadSettings() always evaluated to false. Let me know if the attached patch is fine, and if so I will merge everything. Thank you for the fixes.

[John Beard (john-j-beard)]

That works for me and looks like a simpler solution!

[KiCad Janitor (kicad-janitor)]

Fixed in revision ca91c27852cf3cf355482318d2dfcc71099266d5
https://git.launchpad.net/kicad/patch/?id=ca91c27852cf3cf355482318d2dfcc71099266d5