Page settings and title block info not stored in wks files.

[Eric Karr]

KiCAD Version: 4.0.5+dfsg1-4, release build
wxWidgets: 3.0.2 Unicode and Boost 1.62.0
Platform: Linux 4.9.0-1-686-page i686, 32 bit - Debian stretch

Issue:
When creating a default page template in Pl editor, none of the changes made are saved. The following steps re-create the failure:

1) Open Pl editor
2) Open 'Page Settings' and change the default page size to US ledger (11 x 17)
3) Save the page layout design as "test.kicad_wks"
4) Close the Pl editor
5) Open the Pl editor
6) Open "test.kicad_wks"
7) Sheet is back to default settings..

I've noticed this happens on company name as well, I'm not sure if it actually saves any of the settings. Do not hesitate to contact me if any further information is required.

I also found a report of the same bug from 2014, and it was apparently fixed, but I believe it's been reintroduced:

https://bugs.launchpad.net/kicad/+bug/1405887

Thanks,
Eric

[Seth Hillbrand (sethh)]

I don't observe this with recent master (or with 4.0.7). Is this issue still occurring for you?

[ronnie (ronnie81)]

This is still present / reproducible.

Application: pl_editor
Version: 5.0.0-fee4fd1~65~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-131-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

Huh. I take back my earlier response. I can recreate this, so I must have been testing something separate.

[ronnie (ronnie81)]

@Seth: Sorry for the noise: Actually I *think* this bug is "wont'fix" bcs. none of the page settings [attachment]) are put in the kicad_wks file.

[Seth Hillbrand (sethh)]

You're right, they are not stored. However, I think they should be. As it requires a file format change, I've tentatively targeted it for v6.

[jean-pierre charras (jp-charras)]

Page settings and title block info are never stored in .wkas files, because they are living in .kicad_pcb and .sch files.

Inside pl_editor, these settings are only to test the look of the currently edited .wks file and have no meaning for this file.

[Seth Hillbrand (sethh)]

Fair enough. The page layout format is size-independent. We should definitely document this clearly in the theory of operations section of Pl_Editor's doc file.

It might be useful to store in the pl editor settings the last-used size.

[Jeff Young (jeyjey)]

Moved Page Settings dialog to near the real/preview mode switches and edited the tooltip and headings to make it clearer they were just preview data.

Also implemented storing of the last-used page size and orientation.

[Ian McInerney (imcinerney)]

@Jeff, is preview really the right word to use in this dialog name? I just spent around 10 minutes trying to understand what "preview settings" meant versus the original "page settings" name. I think this should still be called page settings for consistency (since that is what the window is called in Eeschema and Pcbnew), but text should be added in the dialog to say that these are not stored in the worksheet file and are display only (like a 1-2 lines of text at the top).

[Jeff Young (jeyjey)]

@Ian, I think "preview" is the right term. It is *not* page settings because it doesn't save them in the WKS file; they're only used to draw the Preview mode (see the icons in the toolbar).