libedit "discard changes" doesn't properly discard deletion

Bug #1661221 reported by Chris Pavlina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Unassigned

Bug Description

If you delete a component in libedit, then close libedit without saving, libedit asks whether to discard changes. If you then click Yes, it doesn't save the library, but it doesn't restore the state in memory either. This means that the part remains deleted until fully restarting kicad, which could easily cause a user to accidentally save the library again later thinking the delete had been reverted and then actually committing it to the file.

Application: kicad
Version: (2017-02-02 revision 1ab1d8e7e)-master, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.52.1 OpenSSL/1.0.2k zlib/1.2.11 libpsl/0.16.1 (+libicu/58.2) libssh2/1.8.0
Platform: Linux 4.9.6-1-ARCH x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.63.0
Curl: 7.52.1
KiCad - Compiler: GCC 6.3.1 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=OFF
                  KICAD_SCRIPTING_MODULES=OFF
                  KICAD_SCRIPTING_WXPYTHON=OFF
                  KICAD_SCRIPTING_ACTION_MENU=OFF
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=OFF
                  KICAD_USE_OCE=ON

Tags: libedit
Revision history for this message
Maciej Suminski (orsonmmz) wrote :

This works correctly in the new library editor (not merged yet).

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I'm assuming the status of this is fix committed now that the new library editor code has been merged.

Changed in kicad:
status: New → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.