GAL canvas missing rotate command in footprint context menu.

[Wayne Stambaugh]

The footprint context menu is missing the rotate CCW command when using either of the GAL canvases. This command is present in the legacy canvas context menu.

Application: kicad
Version: (2017-01-30 revision f0e0254e2)-master, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.51.0 OpenSSL/1.0.2j zlib/1.2.11 libssh2/1.8.0 nghttp2/1.18.0 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
Curl: 7.51.0
KiCad - Compiler: GCC 6.3.0 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  KICAD_SCRIPTING_ACTION_MENU=OFF
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=ON
                  KICAD_USE_OCE=ON

[John Beard (john-j-beard)]

Why do only footprints have both rotation direction in legacy mode? Is it important, or should the GAL canvases give all items two rotation commands?

[Wayne Stambaugh (stambaughw)]

I'm not sure exactly why but I can tell you that when using rotation
angles < 90°, being able to rotate ccw can be useful. Otherwise, you
have to rotate cw a bunch of times to get to the same angle. Someone
thought it was important enough to add to the legacy canvas so we should
probably add it to the gal canvases as well.

On 1/31/2017 11:19 PM, John Beard wrote:
> Why do only footprints have both rotation direction in legacy mode? Is
> it important, or should the GAL canvases give all items two rotation
> commands?
>

[John Beard (john-j-beard)]

That does make sense. In that case I think adding CW and CCW for all item rotation is probably best. That would also make the code (slightly) simpler with no special casing.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7045ed92fb226cc4647aa19bba9d4b0b3c8d010c
https://git.launchpad.net/kicad/patch/?id=7045ed92fb226cc4647aa19bba9d4b0b3c8d010c