OpenGL anti-aliasing supersampling x4 option causes Pcbnew to crash

[Wayne Stambaugh]

Selecting the OpenGL anti-aliasing supersampling x4 option results in the attached error message followed by a wxWidgets warning about unhandled exceptions. If I click ignore, Pcbnew hangs and must be killed. If I click about, I get a runtime error message.

Application: kicad
Version: (2017-01-11 revision 67b0a8c)-master, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.51.0 OpenSSL/1.0.2j zlib/1.2.8 libssh2/1.8.0 nghttp2/1.16.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
Curl: 7.51.0
KiCad - Compiler: GCC 6.2.0 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=ON
                  KICAD_USE_OCE=ON

[Wayne Stambaugh (stambaughw)]

Here is the exception dialog.

[xzcvczx (xzcvczx)]

just fyi doesn't crash on osx

[jean-pierre charras (jp-charras)]

I confirm this crash (W7 32 bits).
Before the crash this error message is displayed:
Error: creating renderbuffer storage: invalid value

When switching to Subpixel antialiasing (X2 or X4) mode the display does not change, but sometimes (not easily reproductible) Pcbnew crashes when exiting the application.

[Wayne Stambaugh (stambaughw)]

Do you get the error message? It may just be that 4x supersampling
isn't available on my system. If that is the case, the error shouldn't
lead to pcbnew crashing.

On 1/11/2017 7:41 PM, Simon Wells wrote:
> just fyi doesn't crash on osx
>

[Maciej Suminski (orsonmmz)]

I think it might be unavailable on your system, as it does not work on one of my video cards too.
I am going modify the code to handle the error gracefully.

[Wayne Stambaugh (stambaughw)]

That's what I'm looking for. I understand that not all options are
available on every platform but crashing when an anti-aliasing option is
not available is unacceptable. This holds true for all OpenGL options.
The user should get a warning that the option is not available and fall
back to the last usable setting.

On 1/12/2017 10:01 AM, Maciej Sumiński wrote:
> I think it might be unavailable on your system, as it does not work on one of my video cards too.
> I am going modify the code to handle the error gracefully.
>

[KiCad Janitor (kicad-janitor)]

Fixed in revision 88eb648cbb5d5552fef4e9ffd5f57b2f61cfa8ff
https://git.launchpad.net/kicad/patch/?id=88eb648cbb5d5552fef4e9ffd5f57b2f61cfa8ff