undo is broken in libedit

Bug #1636022 reported by Chris Pavlina
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Unassigned

Bug Description

I'm not 100% sure what's going on here, but undo in libedit is...messed up. Sometimes pressing ctrl-Z does nothing, and other times it undoes multiple actions at once. I'd go in more detail if I could discern any real pattern to it... but just start doing things in libedit, ideally a whole bunch of them, and start hitting undo. ¯\_(ツ)_/¯

Application: kicad
Version: (2016-10-19 revision b042cc1)-master, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.50.3 OpenSSL/1.0.2j zlib/1.2.8 libidn/1.33 libssh2/1.7.0
Platform: Linux 4.7.6-1-ARCH x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.61.0
Curl: 7.50.3
KiCad - Compiler: GCC 6.2.1 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=OFF
                  KICAD_SCRIPTING_MODULES=OFF
                  KICAD_SCRIPTING_WXPYTHON=OFF
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=OFF
                  KICAD_USE_OCE=OFF

Tags: libedit
Revision history for this message
Seth Hillbrand (sethh) wrote :

Chris-

Can we close this one?

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

Could be a problem with screen refreshing? It would explain why Ctrl+Z seems to do nothing and after several trials and a screen refresh it instantly undoes a lot of things.

Revision history for this message
Seth Hillbrand (sethh) wrote :

I've been poking at this a bit and can't seem to trigger the behavior with moving, renaming, rotating, etc, which was why I asked if it could be closed. But if you are still seeing the behavior, is there a specific command/sequence that you can reproduce it with?

Revision history for this message
Seth Hillbrand (sethh) wrote :

@orsonmz or Chris, can you say how you trigger this bug? I can't replicate on linux or Mac.

Revision history for this message
Chris Pavlina (pavlina-chris) wrote :

libedit's been seriously overhauled so I doubt this is relevant anymore. I can't repro this either.

Changed in kicad:
status: New → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.