spice simulator: dont' create Spice_Model field if it's equivalent to the implicit values

[Eldar Khayrullin]

I don't know is it intention or not but if I edit Spice Model the Value field coping and creating the Spice_Model field. Then if I change the Value field the Spice_Model field doesn't updated.
In simulator demos (e.g. sallen key sch) I don't see Spice_Model field but if I edit spice model the Spice_Model field creates.

Application: eeschema
Version: 201609180819+7176~55~ubuntu16.04.1-, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-36-generic x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.58.0
Curl: 7.47.0
KiCad - Compiler: GCC 5.4.0 with C++ ABI 1009
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=OFF
                  KICAD_USE_OCE=ON

[jean-pierre charras (jp-charras)]

In net names, when they are used in spice simulator, there are a few constraints:
- some chars are not accepted, because they are separators in directives, for instance ,{}()
- AKAIK, but I can be wrong, only ASCII7 char set is allowed

Currently, only '(' and ')' are replaced by _, because unfortunately I used these char in default net names, and the spice netlist generator replaced these not allowed chars by _ since a long time.

I am not sure replacing not allowed chars in net names is a good idea.
It can create many issues.
An user who want to use spice simulator should know the spice constraints, and must comply and live with them.

[jean-pierre charras (jp-charras)]

Sorry, I sent my answer to the wrong bug report.

[Eldar Khayrullin (eldar)]

OK) You may to hide your answers with click to green text 'Hide'.

[Jeff Young (jeyjey)]

@Devs, is this something we should fix at some point, or is this As Designed?

[Maciej Suminski (orsonmmz)]

If you edit the Spice model, then it means you want something else than the implicit model created based on the reference and value, so I think this is expected.

A possible improvement is to not create any Spice model fields in case the model set in the Spice Model dialog is equal to the implicit one. This ways the implicit model will be used until the user requests a different model. This may also require a checkbox to enforce saving the implicit model, to be discussed.

[KiCad Janitor (kicad-janitor)]

KiCad bug tracker has moved to Gitlab. This report is now available here: https://gitlab.com/kicad/code/kicad/-/issues/2034