kicad version is stuck on BZR 7083 after git transition.

[firewalker]

kicad version is stuck on BZR 7083 after git transition.

Application: kicad
Version: (2016-08-20 BZR 7083)-product, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.50.0 OpenSSL/1.0.2h zlib/1.2.8 libidn/1.33 libssh2/1.7.0
Platform: Linux 4.6.4-1-ARCH i686, 32 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
Curl: 7.50.0
KiCad - Compiler: GCC 6.1.1 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  USE_FP_LIB_TABLE=HARD_CODED_ON
                  BUILD_GITHUB_PLUGIN=ON

[Nick Østergaard (nickoe)]

Where did you get your build from?

[Nick Østergaard (nickoe)]

If the AUR, this is not the place to report the issue, it should be reported to the maintainer of the package.

[firewalker (firew4lker)]

I cloned the new git repository and build it my self.

cmake ../.. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr -DKICAD_SKIP_BOOST=ON \
  -DBUILD_GITHUB_PLUGIN=ON -DKICAD_SCRIPTING=ON -DKICAD_SCRIPTING_MODULES=ON \
  -DKICAD_SCRIPTING_WXPYTHON=ON -DUSE_WX_GRAPHICS_CONTEXT=OFF -DUSE_WX_OVERLAY=OFF -DKICAD_SPICE=ON\

git log -n 1

commit 36ff4b5e93f6add2ba4a3dd05e6e4a816fb7d59c
Merge: 9d5300b ca499b8
Author: jp-charras <email address hidden>
Date: Thu Aug 25 09:37:20 2016 +0200

    Merge branch 'master' of git+ssh://git.launchpad.net/kicad

[firewalker (firew4lker)]

The generated file kicad_build_version.h contains always

/* Do not modify this file, it was automatically generated by CMake. */

/*
 * Define the KiCad build version string.
 */
#ifndef __KICAD_VERSION_H__
#define __KICAD_VERSION_H__

#define KICAD_BUILD_VERSION "(2016-08-20 BZR 7083)"

#endif /* __KICAD_VERSION_H__ */

[Nick Østergaard (nickoe)]

What do you mean by stuck then? A merge itself does not increment the bzr style number, only the commits that a merge pulls into the branch. This is the expected behaivour.

[Maciej Suminski (orsonmmz)]

We should change it to git revisions, otherwise the version information in bug reports will be irrelevant.

[jean-pierre charras (jp-charras)]

On my computer, for the same kicad version, the KICAD_BUILD_VERSION is:
#define KICAD_BUILD_VERSION "(2016-08-25 BZR 7095, Git 36ff4b5)"

the line:
#define KICAD_BUILD_VERSION "(2016-08-20 BZR 7083)"
looks incorrect (outdated).
(the date given by log is Date: Thu Aug 25 09:37:20 2016 +0200)

[firewalker (firew4lker)]

I will clone the git repo again and try it.

git clone https://git.launchpad.net/kicad

[Nick Østergaard (nickoe)]

yeah, so you expected updates to the bzr repo... that is not updated anymore.

[firewalker (firew4lker)]

No, you still don't understand the issue. I was expecting BZR version to be replaced by GIT commit hash. Like JP's case(2016-08-25 BZR 7095, Git 36ff4b5) . I am building the brand new git repo.

But since it is working properly for JP, the problem exists to my end.

[Nick Østergaard (nickoe)]

Does your directory contain a .bzr folder?

[firewalker (firew4lker)]

The fresh cloned one, no. Didn't check the old one before deleting it though. Could the git clone command fetched the .bzr repo and the script was checking it to create the version?

I didn't yet tested the fresh cloned repo.

[Nick Østergaard (nickoe)]

So please check if there is a .bzr or .git or both for some magical reason.

[firewalker (firew4lker)]

The new build is ok (like JP's). There is only the .git directory as expected.