Comment 11 for bug 1606378

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1606378] Re: While single-left-clicking on the "window frame" of Pcbnew, window jumps to bottom half of the screen.

On 7/31/2016 2:42 PM, jean-pierre charras wrote:
> It happens when a context menu (popup menu) is opened and later, closed by left clicking on the frame caption (dark blue area on the top of the frame on Windows)
> This is a corner case.
>
> It is due to the fact the mouse cursor is moved (by the kicad code) to its initial position
> (what is expected) and then the left click is proceeded.
>
> The attached patch should fix that (it allows the left click mouse event to be proceeded before moving the cursor).
> I tested it on W7 32 bits, but it needs to be tested on different OS.
>
> ** Patch added: "fix_left_click_mouse_issue.diff"
> https://bugs.launchpad.net/kicad/+bug/1606378/+attachment/4711059/+files/fix_left_click_mouse_issue.diff
>

@JP, your patch fixes the issue on windows. I guess the fix wasn't as
complicated as I thought it would be. I tested Linux before I applied
the patch. Debian testing with Gnome's WM (at least my build) does not
suffer from this problem. Applying your patch didn't seem to break
anything on Linux but I didn't do any exhaustive testing. Can someone
test if this is a problem on OSX and then test with the patch to see if
it breaks anything? If the patch doesn't break anything on any
platform, I would prefer that we not add the #ifdef __WXMSW__/#endif
around wxSafeYield(). If the patch breaks anything than I guess we will
have to life with the conditional compilation.