No warning for duplicate pins in different units

[Chris Pavlina]

If a part has a pin duplicated across multiple units, "No off grid or duplicate pins were found" is still displayed. I get the intent - sometimes duplicating a pin across units is desirable, for shared pins. But they're still duplicate pins, just intentional ones, and it shouldn't explicitly say there were none, IMO.

[Novak Tamas (novak-7)]

I have "common to all units.." checkbox for each pins. If I set this, pin will be spread to all units and no error report on that..as expected.

But if I add a pin 2 to Unit A and a pin 2 to unit B ("common to all.." is *not* ticked for both pins!), then I click Test ladybug, I expect an error message, but still get a "no offgrid or duplicate pins were found"

[jean-pierre charras (jp-charras)]

You are expecting an error message, but your expectation is wrong.
I don't know why you are thinking this is a bug, and even why you are expecting an error message.
If the same pin (like a 3State control) is common to different units, a pin with the same number is needed for each unit is needed.

Using common or separate pins do not change anything in schematic.
They only change an internal representation and anything else for the user (or perhaps allows a more flexible drawing shape (different position/different size for each unit).

And, to tell the true, users are expected to known what they are doing, and an automatic error detection cannot replace user knowledge and competence.

[Novak Tamas (novak-7)]

@JP, I really can't understand...
Please see attached video where
- I create a new part with 2 units, units are not interchangeable.
- I place a pin 1 to unit A (pin named "A")
- I place a pin 1 to unit B (pin named "B")
Both pins are NOT "common to all units in component".

You mean it is not forbidden? pin 1 is assigned to two different units at different names.
IMO duplicate testing should find it a problem.

[jean-pierre charras (jp-charras)]

74HC244 is a basic example of units which cannot be fully interchangeable, cannot have a OE control common, and therefore can use duplicate pin 1 and duplicate pin 19.

I maintain duplicate pins in different units cannot be forbidden (although the case is not frequent)

An other frequent case is power pins in op amps and gates.

And again:
Using common or separate pins do not change anything in schematic (they are different pins at schematic level).

[Novak Tamas (novak-7)]

@JP sorry, the whole concept is not clear to me.

For 74HC244 I'd make
- two units,
- they ARE interchangeable (==unticked "all units are not interchangeable"),
- GND and VCC (pin 10 and 20) are "common to all units".
- all the other pins (A1..4, Y1..4, OE) are not "common to all units": they have different pin numbers on each unit.

Or you mean with "example of units which cannot be fully interchangeable" when having 8 units?

You stated in #4 "duplicate pins in different units cannot be forbidden". IMO they must be forbidden if not marked as "common to all units".

[Jeff Young (jeyjey)]

This appears to have been fixed. If you create two pins with the same number and not common-to-all-units, they will be flagged regardless of name, position, etc.