inconsistent names for polar coordinates

Bug #1545107 reported by Jonas Stein
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Jeff Young

Bug Description

The footer prints coordinates as Ro and Th (probably rho and theta), while the icon uses phi and r.
I suggest to unify it to phy and r.

Here is the related part in the code I found so far

$ grep -R "Ro" | grep "formatter"
pcbnew/basepcbframe.cpp: formatter = wxT( "Ro %.6f Th %.1f" );
pcbnew/basepcbframe.cpp: formatter = wxT( "Ro %.6f Th %.1f" );
pcbnew/basepcbframe.cpp: formatter = wxT( "Ro %f Th %f" );
gerbview/gerbview_frame.cpp: formatter = wxT( "Ro %.6f Th %.1f" );
gerbview/gerbview_frame.cpp: formatter = wxT( "Ro %.5f Th %.1f" );
gerbview/gerbview_frame.cpp: formatter = wxT( "Ro %f Th %f" );

Tags: pcbnew
xzcvczx (xzcvczx)
Changed in kicad:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Jonas Stein (news-g) wrote :

Correction of my typo: I suggest to unify it to phi and r.

Revision history for this message
Jeff Young (jeyjey) wrote :

Assuming we don't have platform issues, how about r and φ?

Revision history for this message
Jeff Young (jeyjey) wrote :

Given that the degree symbol doesn't work on MSW, the phi symbol probably won't either.

Revision history for this message
Jeff Young (jeyjey) wrote :

According to Wolfram, theta is used for the angle in the XY plane, while phi is used for the angle out of the XY plane (the zenith angle).

It looks like it's the icon that's wrong.

Revision history for this message
Nick Østergaard (nickoe) wrote :

@Jeff, what makes you say that the degree symbol does not work on MSW?

Just make it translatable and have the translations use the correct unicode characters.

tags: added: pcbnew
Revision history for this message
jean-pierre charras (jp-charras) wrote :

the ° symbol ( I am guessing we are talking about this symbol) is not a ASCII 7 code.
So it should not be used in translatable strings.

I do not really understand the meaning of "make it translatable"

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 5010a461e11c74438f2f7e192171a26ce61dc08d
https://git.launchpad.net/kicad/patch/?id=5010a461e11c74438f2f7e192171a26ce61dc08d

Changed in kicad:
status: Confirmed → Fix Committed
assignee: nobody → Jeff Young (jeyjey)
Revision history for this message
Jeff Young (jeyjey) wrote :

@JP, I'm not actually sure. I put the symbol in some dialogs and Wayne later fixed them to not include the symbols. Not sure what the issue was.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1545107] Re: inconsistent names for polar coordinates

I was getting gibberish on windows 10 when the degree symbols was used
in dialogs created by wxFormbuilder so I replaced them. I don't know if
the issues is wxfb or windows but it was not acceptable.

On 05/18/2018 06:32 AM, Nick Østergaard wrote:
> @Jeff, what makes you say that the degree symbol does not work on MSW?
>
> Just make it translatable and have the translations use the correct
> unicode characters.
>
> ** Tags added: pcbnew
>

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.