pcbnew segfaults with kicad_mod cmdline argument

[Chris Pavlina]

Pass pcbnew a kicad_mod file as a command line argument, it segfaults.

Hopefully this weekend I'll have a chance to look at this myself, just putting up a report to track it and maybe discuss.

What do we think is the correct way to handle this? Part of me would really like if it could automatically launch the footprint editor and load the file, but I'm not 100% sure how the best way to make that work would be, since you're not opening a project or anything. Obviously the easiest answer is to just give a proper error message rather than segfaulting - that's what I'll do if nobody comments on the first idea before the weekend.

[Seth Hillbrand (sethh)]

If it helps to track down, I'm not seeing that segfault. I get an appropriate error message (attached).

I would second the suggestion to open the footprint editor when passed kicad_mod files.

Application: kicad
Version: (2017-08-09 revision b45af7f42)-master, debug build
Libraries: wxWidgets 3.0.2
           libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-3-amd64 x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.60.0
Curl: 7.52.1
KiCad - Compiler: GCC 6.3.0 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  KICAD_SCRIPTING_ACTION_MENU=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_OCE=ON

[Seth Hillbrand (sethh)]

Addendum: Sorry, somehow I missed the date on this original post. :( Of course you have fixed it by now!

[Wayne Stambaugh (stambaughw)]

Who ever fixed this forgot to mark it as fixed in the commit comment. The status of this bug report should be fix committed.

As for opening the footprint library editor, that is not a straight forward issue. The footprint library editor is library centric in that it is designed to create a library rather than a single footprint file. I'm guessing some major refactoring of the the footprint library editor would have to happen before this change could be made. I'm curious as to how a footprint file got passed to the board editor. If it was via the command line then the error message is the appropriate response as the board editor cannot edit footprint libraries.

[Nick Østergaard (nickoe)]

I have not tested it, but I think it was fixed in:
https://git.launchpad.net/kicad/commit/?id=7b5ab741bb0daf2408216c7c6e745b02e4b9697f