Zone type stuck at "keepout" after editing keepout

[Chris Pavlina]

The following sequence of steps results in a keepout zone being placed when the user intended to place a copper fill zone. The tool then gets stuck in this mode until pcbnew is restarted. All of these steps can be performed on a blank PCB file with "no net" zones, and have only been tested in GAL.

1. Draw a filled zone on F.Cu
2. Draw a keepout zone on F.Cu, completely outside the zone in step 1.
3. Draw a filled zone on F.Cu, completely outside both previous zones.
4. Duplicate the keepout zone by pressing Ctrl-D over it; place the new keepout also nonintersecting.
5. Edit the duplicate zone from step 4 and switch it to B.Cu.
6. Draw a filled zone on F.Cu.

The zone tool indicates that it is placing a copper fill, but actually places a keepout.

Application: pcbnew
Version: (2015-12-31 BZR 6410, Git 960dece)-product debug build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.2.1,wx containers,compatible with 2.8)
Platform: Linux 4.3.3-2-ARCH x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.60.0
libcurl version: 7.46.0 (with SSL - OpenSSL/1.0.2e)
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

Marking confirmed as someone else reported this directly to me and I was able to reproduce it.

[Johannes Agricola (johannes-agricola)]

It's even easier:

1. Draw a keepout zone on F.Cu
2. Edit the zone and switch it to B.Cu.
3. Draw a filled zone on F.Cu

[Chris Pavlina (pavlina-chris)]

Indeed, I can confirm this in 6428.

[Johannes Agricola (johannes-agricola)]

I looked up how it was done with the legacy canvas. They manually set the keepout flag. See PCB_EDIT_FRAME::Begin_Zone. The following patch does the same in the drawing tool.

[Wayne Stambaugh (stambaughw)]

@Chris, please keep an eye on the coding style before you commit
patches. This one is missing spaces inside the parentheses:

zoneInfo.SetIsKeepout(aKeepout);

should be

zoneInfo.SetIsKeepout( aKeepout );

On 1/7/2016 2:43 PM, Chris Pavlina wrote:
> ** Changed in: kicad
> Status: In Progress => Fix Committed
>

[Chris Pavlina (pavlina-chris)]

Got it, sorry for that. I'll have it fixed shortly.

[xzcvczx (xzcvczx)]

Commit 6205 in 4.0 branch, Released in 4.0.2