FP Editor in GAL mode: Ref&Val visibility problemss

[Piotr]

Application: kicad
Version: (2015-11-17 BZR 6318, Git 7f9a073)-product release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1009,GCC 5.2.0,wx containers,compatible with 2.8)
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Boost version: 1.57.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

Noticed it while making a few new footprints: switching the visibility of the Ref** text back and forth generates a second copy of the text with opposite visibility setting.
Here is an animated gif showing the artifacts:
http://i.imgur.com/4Sevcm8.gifv

Steps to reproduce:
1. Fire up the FP Editor and load a footprint
2. Click on the Ref** text and switch it to invisible
3. Switch the visibility again to visible
4. Move the text somewhere else
5. As soon as you deselect the text, a 2nd copy of it shows up at the previous location

After some more testing the Val** also started to clone itself. The "ghost" copy disappears as soon as you click on the text. Shows up immediately after deselecting the text.

http://i.imgur.com/wpvrb7z.png

Switching to Default mode and back removes the copies, but they will show up as soon as you start to change the visibility settings.

--
Piotr

[Piotr (pzapart)]

The problem is actually GAL related, shows up in pcbnew too:

http://i.imgur.com/O2CimAf.png

The same way to reproduce: cycle the visibility of the text and move it, then deselect the component.

--
Piotr

[xzcvczx (xzcvczx)]

Cant reproduce are you able to try it with stable and see if its still occurring

[Piotr (pzapart)]

Yes, it's still occuring with stable 4.02:

Application: kicad
Version: 4.0.2-stable release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1009,GCC 5.2.0,wx containers,compatible with 2.8)
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Boost version: 1.57.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

Footprint editor:
http://imgur.com/3ftYP9q

PCBNew:
http://imgur.com/ksZJrLZ

The problem does not show up on Linux Mint using build 6852. Looks like it's windows related.

[Novak Tamas (novak-7)]

I think I can reproduce not exactly the above, but probably the same phenomenon.
See video attached in 4.0.2 stable Win7/SP1/x64:

1 - in pcb_new hover over a value
2 - push E to edit
3 - Change Layer from F.Fab to F.SilkS
4 - click OK
5 - hover over the same value again
5 - push E again
6 - change Layer back to F.Fab
7 - click OK
8 - move mouse scroll (a little zoom in or out)
9 - Value's color changes to the mix of F.Fab and F.SilkS (issue!!)
10 - hover over Value again
11 - push M to move
12 - move Value by mouse and click to end move
13 - both F.Fab and F.SilkS text is visible at two different places
14 - Value will be in this bad state until you select it with mouse click.

Even more: newer 6852 doesn't do the above. It is worse, as it crashes:

1 - in pcb_new 6852 select a Value by clicking on it.
2 - push E to edit
3 - Change Layer from F.Fab to F.SilkS
4 - click OK
5 - click to select the same value again
5 - push E again
6 - change Layer back to F.Fab
7 - click OK
9 - Value's color changes to the mix of F.Fab and F.SilkS
10 - wait a second and pcb_new gets crashed.

[Novak Tamas (novak-7)]

It seems to be fixed. I can't reproduce any of the above phenomenons in nightly 7083. Still I'm gonna check in 4.0.4 stable.

[Piotr (pzapart)]

I can't reproduce the above steps (crashing or changing colors) in 4.0.4 stable on windows, but the ghosting i described in my initial report is still there:
FP editor: http://i.imgur.com/eaIWVw7.png
PCBnew: http://i.imgur.com/oV7748Q.png

However, i noticed something weird. I have a two monitor setup with different resolutions on both.
If i open the project and open the PCBnew in my main monitor (1920x1200) then the problem with ghost values/references after cycling the visibility persists.

But! If i open the project, then the PCBnew and then immediately move it to the secondary monitor (1280x1024), cycle the visibility, the issue is not there. I can change the visibility back and forth, no grey copy shows up.

Now, having my PCBnew window on the secondary, smaller monitor, when i move the window back to the main monitor, cycle the REF visibility, the problem shows up.

Once generated, the ghost text is still there even if i move the window between monitors. Goes away only after changing the canvas (or just pressing F11).

Application: kicad
Version: 4.0.4-stable release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1009,GCC 5.2.0,wx containers,compatible with 2.8)
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Boost version: 1.57.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

[Novak Tamas (novak-7)]

Piotr is right, issue is still with us in 4.0.4 stable, and even worse: nightly 7083 crashed from the sequence described in the original report.

[Novak Tamas (novak-7)]

The same happens in newborn 7146 nightly.

If I
- hover over the Ref
- push E to edit
- click Display - Invisible
- click OK on Footprint Text Properties dialog
- hover over the Ref again
- push E to edit
- click Display - Visible
- click OK on Footprint Text Properties dialog
- hover over the Ref again
- push M to move
... no double label after moving, no crash, all fine as expected

but when I
- hover over the Ref
- CLICK TO SELECT
- push E for set to invisible
- click OK on Footprint Text Properties dialog
- hover over the Ref again
- (this time doesn't count if I click to select or not)
- push E to edit
- click Display - Visible
- click OK on Footprint Text Properties dialog
- boom, crash!!

Application: kicad
Version: (2016-09-10 revision 7ad2f37)-makepkg, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.46.0 OpenSSL/1.0.2d zlib/1.2.8 libidn/1.32 libssh2/1.6.0 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.57.0
Curl: 7.46.0
KiCad - Compiler: GCC 5.2.0 with C++ ABI 1009
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=ON
                  KICAD_USE_OCE=ON

[Maciej Suminski (orsonmmz)]

@Novak Tamas,
I have tried both with Linux & Windows 7, layout editor & footprint editor, standalone/project mode - all possible combinations and I could not crash it. Can you confirm the bug is still there? Does it happen with Cairo as well?

@Piotr
Unfortunately, the stable release is already out. It is not a critical bug (software does not crash), so it is likely to be fixed in the next release.

[Maciej Suminski (orsonmmz)]

Ok, I have also reverted to the revision mentioned in the bug report and I confirm it used to crash. With the current revision everything seems fine, hence I mark the bug as resolved. Feel free to change its status if you think otherwise.

[Wayne Stambaugh (stambaughw)]

Orson,

Does this fix need to be applied to the stable 4 branch? If so, please
apply it.

Thanks,

Wayne

On 9/15/2016 10:40 AM, Maciej Sumiński wrote:
> Ok, I have also reverted to the revision mentioned in the bug report and
> I confirm it used to crash. With the current revision everything seems
> fine, hence I mark the bug as resolved. Feel free to change its status
> if you think otherwise.
>
> ** Changed in: kicad
> Status: Confirmed => Fix Committed
>

[Novak Tamas (novak-7)]

@Orson,
Confirmed: I've just downloaded 7155 and can't see the issue!!

Both nightly 7146 (which was the freshest version 4 days ago (09.11), and 4.0.4 stable fail in both OpenGL and Cairo. If there is a patch having been applied recently then this fix should do to the upcoming 4.0.5(?) stable.
If issue passed away accidently, then try to investigate the reason in bad 7146.

[Piotr (pzapart)]

I can't crash the 4.0.4 Stable using the steps above. It's just leaves that copy on the invisible text layer. Which frankly is not that big deal. Hitting F11 is getting rid of it.
This bug was just something i noticed by accident while creating footprints.
Keep up the good work! :)

--
Piotr

[Maciej Suminski (orsonmmz)]

@Wayne,

It has been fixed as a side effect of the recent undo buffer refactoring. From what I see, it does not crash in 4.0.4, but cause a ghosting effect, which surely is annoying, but not critical. It is hard to point a single commit that has fixed the issue, so probably I would leave the stable branch without changes for now. Otherwise we would have to backport the whole undo buffer refactor which is not very well tested yet.