No hint for top "Selection" icon on right vertical toolbar

[Novak Tamas]

title tells the whole story: if I hover over icons, all have a hint..except the top one.

[xzcvczx (xzcvczx)]

what would you expect to see for the top one

[Novak Tamas (novak-7)]

Selection ?

[Vincent G (vghd)]

Fixed by adding "Select Item" string in tool_sch.cpp & help_common_strings.h

Also changed "highlight net" to a static string in help_common_strings.h ==> WAS string in tools_sch.cpp

[Vincent G (vghd)]

Tested with success on my computer. Ubuntu 17 Current Build. Since I can't commit anything to the repository, here are the modifications:

help_common_strings.h: ADDED

// Schematic editor:
#define HELP_SELECT _( "Select item" )
#define HELP_HIGHLIGHT _( "Highlight net" )

tools_sch.cpp : MODIFIED
// Set up toolbar
m_drawToolBar->AddTool( ID_NO_TOOL_SELECTED, wxEmptyString, KiScaledBitmap( cursor_xpm, this ),
                            HELP_SELECT, wxITEM_CHECK );

m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString,
                            KiScaledBitmap( net_highlight_schematic_xpm, this ),
                            HELP_HIGHLIGHT, wxITEM_CHECK );

[Vincent G (vghd)]

Patch file

[Nick Østergaard (nickoe)]

fix comitted is for when the fix is comitted on master.

[Maciej Suminski (orsonmmz)]

We have already reached the string freeze stage of v5 release, so we try to avoid introducing new texts to give the translation team to work on their part. Thank you for the patch, we will commit it in v6.

[Nick Østergaard (nickoe)]

I guess we could add this to 5.0.1?

[Nick Østergaard (nickoe)]

But thinking twice, this is not really that critical and should probably just be merged on master only.

[Nick Østergaard (nickoe)]

@Vincent, it looks like this only adds the hint for eeschema, but not for pcbnew.

[KiCad Janitor (kicad-janitor)]

Fixed in revision e94752a6cff929c5cd7c43f4bfd301f83a8e3d2f
https://git.launchpad.net/kicad/patch/?id=e94752a6cff929c5cd7c43f4bfd301f83a8e3d2f

[Seth Hillbrand (sethh)]

@Vincent- I modified your patch and pushed to the repository. Thank you for your contribution to KiCad!