No hint for top "Selection" icon on right vertical toolbar

Bug #1497737 reported by Novak Tamas on 2015-09-20
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Wishlist
Vincent G

Bug Description

title tells the whole story: if I hover over icons, all have a hint..except the top one.

tags: added: pcbnew
xzcvczx (xzcvczx) wrote :

what would you expect to see for the top one

Novak Tamas (novak-7) wrote :

Selection ?

Novak Tamas (novak-7) on 2016-06-03
Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
Jeff Young (jeyjey) on 2018-02-15
tags: added: starter
Vincent G (vghd) wrote :

Fixed by adding "Select Item" string in tool_sch.cpp & help_common_strings.h

Also changed "highlight net" to a static string in help_common_strings.h ==> WAS string in tools_sch.cpp

Changed in kicad:
assignee: nobody → Vincent G (vghd)
status: Triaged → In Progress
Vincent G (vghd) wrote :

Tested with success on my computer. Ubuntu 17 Current Build. Since I can't commit anything to the repository, here are the modifications:

help_common_strings.h: ADDED

// Schematic editor:
#define HELP_SELECT _( "Select item" )
#define HELP_HIGHLIGHT _( "Highlight net" )

tools_sch.cpp : MODIFIED
// Set up toolbar
m_drawToolBar->AddTool( ID_NO_TOOL_SELECTED, wxEmptyString, KiScaledBitmap( cursor_xpm, this ),
                            HELP_SELECT, wxITEM_CHECK );

m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString,
                            KiScaledBitmap( net_highlight_schematic_xpm, this ),
                            HELP_HIGHLIGHT, wxITEM_CHECK );

Changed in kicad:
status: In Progress → Fix Committed
Vincent G (vghd) wrote :

Patch file

Vincent G (vghd) on 2018-06-03
tags: added: eeschema
Nick Østergaard (nickoe) wrote :

fix comitted is for when the fix is comitted on master.

Changed in kicad:
status: Fix Committed → New
Maciej Suminski (orsonmmz) wrote :

We have already reached the string freeze stage of v5 release, so we try to avoid introducing new texts to give the translation team to work on their part. Thank you for the patch, we will commit it in v6.

Changed in kicad:
milestone: none → 6.0.0-rc1
ronnie (ronnie81) on 2018-08-25
Changed in kicad:
status: New → In Progress
tags: removed: starter
Nick Østergaard (nickoe) wrote :

I guess we could add this to 5.0.1?

Changed in kicad:
milestone: 6.0.0-rc1 → 5.0.1
Nick Østergaard (nickoe) wrote :

But thinking twice, this is not really that critical and should probably just be merged on master only.

Changed in kicad:
milestone: 5.0.1 → 5.1.0
Nick Østergaard (nickoe) wrote :

@Vincent, it looks like this only adds the hint for eeschema, but not for pcbnew.

KiCad Janitor (kicad-janitor) wrote :

Fixed in revision e94752a6cff929c5cd7c43f4bfd301f83a8e3d2f
https://git.launchpad.net/kicad/patch/?id=e94752a6cff929c5cd7c43f4bfd301f83a8e3d2f

Changed in kicad:
status: In Progress → Fix Committed
Seth Hillbrand (sethh) wrote :

@Vincent- I modified your patch and pushed to the repository. Thank you for your contribution to KiCad!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers