Save Hotkeys crash

[Martin d'Allens]

Steps to reproduce:
- Launch KiCad
- Open the menu: Hotkeys -> Export Hotkeys
- The following backtrace is shown.

Application: kicad
Version: (2015-07-27 BZR 5997, Git 0784295)-product debug build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.8.4,wx containers,compatible with 2.8)
Platform: Linux 3.13.0-58-generic x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.54.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=OFF
         KICAD_SCRIPTING_MODULES=OFF
         KICAD_SCRIPTING_WXPYTHON=OFF
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

ASSERT INFO:
../src/common/fldlgcmn.cpp(96): assert "!(HasFdFlag(wxFD_SAVE) && HasFdFlag(wxFD_OPEN))" failed in Create(): can't specify both wxFD_SAVE and wxFD_OPEN at once

BACKTRACE:
[1] wxFileDialogBase::Create(wxWindow*, wxString const&, wxString const&, wxString const&, wxString const&, long, wxPoint const&, wxSize const&, wxString const&)
[2] wxFileDialog::Create(wxWindow*, wxString const&, wxString const&, wxString const&, wxString const&, long, wxPoint const&, wxSize const&, wxString const&)
[3] wxFileDialog::wxFileDialog(wxWindow*, wxString const&, wxString const&, wxString const&, wxString const&, long, wxPoint const&, wxSize const&, wxString const&)
[4] wxFileSelector(wxString const&, wxString const&, wxString const&, wxString const&, wxString const&, int, wxWindow*, int, int)
[5] EDA_FileSelector(wxString const&, wxString const&, wxString const&, wxString const&, wxString const&, wxWindow*, int, bool, wxPoint const&) /home/martin/tmp/kicad-source-mirror/common/gestfich.cpp:132
[6] EDA_BASE_FRAME::ExportHotkeyConfigToFile(EDA_HOTKEY_CONFIG*, wxString const&) /home/martin/tmp/kicad-source-mirror/common/hotkeys_basic.cpp:798
[7] KICAD_MANAGER_FRAME::Process_Config(wxCommandEvent&) /home/martin/tmp/kicad-source-mirror/kicad/mainframe.cpp:541
[8] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[9] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[10] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[11] wxEvtHandler::TryHereOnly(wxEvent&)
[12] EDA_BASE_FRAME::ProcessEvent(wxEvent&) /home/martin/tmp/kicad-source-mirror/common/basicframe.cpp:164
[13] wxEvtHandler::DoTryChain(wxEvent&)
[14] wxEvtHandler::ProcessEvent(wxEvent&)
[15] wxWindowBase::TryAfter(wxEvent&)
[16] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[17] wxMenuBase::SendEvent(int, int)
[18] g_closure_invoke
[19] g_signal_emit_valist
[20] g_signal_emit
[21] g_main_context_dispatch
[22] g_main_loop_run
[23] gtk_main
[24] wxGUIEventLoop::DoRun()
[25] wxEventLoopBase::Run()
[26] wxAppConsoleBase::MainLoop()
[27] APP_KICAD::OnRun() /home/martin/tmp/kicad-source-mirror/kicad/kicad.cpp:274
[28] wxEntry(int&, wchar_t**)
[29] main /home/martin/tmp/kicad-source-mirror/kicad/kicad.cpp:306
[30] __libc_start_main
[31] _start

[Nick Østergaard (nickoe)]

I don't get a crash in:
Application: kicad
Version: (2015-07-17 BZR 5958)-kicad release build
wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1008,GCC 5.1.0,wx containers,compatible with 2.8)
Platform: Linux 4.1.2-2-ARCH x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.58.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

[jean-pierre charras (jp-charras)]

This is not a crash. Just a debug minor warning, I am guessing.

[Wayne Stambaugh (stambaughw)]

I committed a fix for this the product branch r6034.